From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8ks9-0000ED-C8 for qemu-devel@nongnu.org; Wed, 18 Apr 2018 07:03:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8ks6-0006Y2-4w for qemu-devel@nongnu.org; Wed, 18 Apr 2018 07:03:33 -0400 References: <1523819244-29954-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1523819244-29954-4-git-send-email-akrowiak@linux.vnet.ibm.com> <819cba2d-32d7-6a5c-978f-1c6aa04872fa@linux.vnet.ibm.com> From: David Hildenbrand Message-ID: <28f80970-6cd3-d28d-df3a-2f80b5252f00@redhat.com> Date: Wed, 18 Apr 2018 13:03:13 +0200 MIME-Version: 1.0 In-Reply-To: <819cba2d-32d7-6a5c-978f-1c6aa04872fa@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic , Tony Krowiak , qemu-devel@nongnu.org Cc: mjrosato@linux.vnet.ibm.com, peter.maydell@linaro.org, alifm@linux.vnet.ibm.com, eskultet@redhat.com, pmorel@linux.vnet.ibm.com, cohuck@redhat.com, heiko.carstens@de.ibm.com, alex.williamson@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, jjherne@linux.vnet.ibm.com, schwidefsky@de.ibm.com, pbonzini@redhat.com, bjsdjshi@linux.vnet.ibm.com, eric.auger@redhat.com, rth@twiddle.net On 18.04.2018 12:55, Halil Pasic wrote: > > > On 04/15/2018 09:07 PM, Tony Krowiak wrote: >> A new CPU model feature and two new CPU model facilities are >> introduced to support AP devices for a KVM guest. > [..] >> diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c >> index 3b9e274..5ee3a2d 100644 >> --- a/target/s390x/cpu_features.c >> +++ b/target/s390x/cpu_features.c >> @@ -40,8 +40,10 @@ static const S390FeatDef s390_features[] = { >> FEAT_INIT("srs", S390_FEAT_TYPE_STFL, 9, "Sense-running-status facility"), >> FEAT_INIT("csske", S390_FEAT_TYPE_STFL, 10, "Conditional-SSKE facility"), >> FEAT_INIT("ctop", S390_FEAT_TYPE_STFL, 11, "Configuration-topology facility"), >> + FEAT_INIT("apqci", S390_FEAT_TYPE_STFL, 12, "Query AP Configuration facility"), > > Why did you change this form qci to apqci. Too may people found the > qci good? If the facility is called "Query AP Configuration facility" it should be qapc Where does the term "qci" come from ? > >> FEAT_INIT("ipter", S390_FEAT_TYPE_STFL, 13, "IPTE-range facility"), >> FEAT_INIT("nonqks", S390_FEAT_TYPE_STFL, 14, "Nonquiescing key-setting facility"), >> + FEAT_INIT("apft", S390_FEAT_TYPE_STFL, 15, "Adjunct Processor Facilities Test facility"), >> FEAT_INIT("etf2", S390_FEAT_TYPE_STFL, 16, "Extended-translation facility 2"), >> FEAT_INIT("msa-base", S390_FEAT_TYPE_STFL, 17, "Message-security-assist facility (excluding subfunctions)"), >> FEAT_INIT("ldisp", S390_FEAT_TYPE_STFL, 18, "Long-displacement facility"), >> @@ -129,6 +131,7 @@ static const S390FeatDef s390_features[] = { >> >> FEAT_INIT_MISC("dateh2", "DAT-enhancement facility 2"), >> FEAT_INIT_MISC("cmm", "Collaborative-memory-management facility"), >> + FEAT_INIT_MISC("ap", "AP facilities installed"), > > Why plural ('facilities')? Would not s/facilities/instructions be more end-user > friendly? > > Regards, > Halil > -- Thanks, David / dhildenb