From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 0/7] hw/misc/empty_slot: Spring cleaning
Date: Sun, 24 May 2020 18:58:00 +0200 [thread overview]
Message-ID: <2906ea36-d6c4-f05b-3242-d9380986d48c@redhat.com> (raw)
In-Reply-To: <20200510152840.13558-1-f4bug@amsat.org>
ping?
On 5/10/20 5:28 PM, Philippe Mathieu-Daudé wrote:
> New Spring, new opportunity to clean this device :)
> (v1 was in 2018, v2 in 2019).
>
> - lower device priority
> - follow qdev model and use properties
> - convert to trace events
> - describe with slot name
> - move under hw/misc/ and cover in MAINTAINERS
>
> Peter, I hope you are OK adding it wit UNIMP device,
> as both are very similar, and don't have much activity.
>
> Only MIPS/SPARC32 targets use this device.
>
> v2: https://www.mail-archive.com/qemu-devel@nongnu.org/msg626498.html
> v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg564060.html
>
> Philippe Mathieu-Daudé (7):
> hw/sparc/sun4m: Use UnimplementedDevice for I/O devices
> hw/misc/empty_slot: Lower address space priority
> hw/misc/empty_slot: Convert 'size' field as qdev property
> hw/misc/empty_slot: Add a 'name' qdev property
> hw/misc/empty_slot: Convert debug printf() to trace event
> hw/misc/empty_slot: Move the 'hw/misc' and cover in MAINTAINERS
> hw/misc/empty_slot: Name the slots when created
>
> include/hw/empty_slot.h | 9 -------
> include/hw/misc/empty_slot.h | 19 ++++++++++++++
> hw/mips/mips_malta.c | 4 +--
> hw/{core => misc}/empty_slot.c | 47 +++++++++++++++++++---------------
> hw/sparc/sun4m.c | 23 +++++++++++------
> MAINTAINERS | 4 ++-
> hw/core/Makefile.objs | 1 -
> hw/misc/Makefile.objs | 1 +
> hw/misc/trace-events | 4 +++
> 9 files changed, 70 insertions(+), 42 deletions(-)
> delete mode 100644 include/hw/empty_slot.h
> create mode 100644 include/hw/misc/empty_slot.h
> rename hw/{core => misc}/empty_slot.c (66%)
>
next prev parent reply other threads:[~2020-05-24 16:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 15:28 [PATCH 0/7] hw/misc/empty_slot: Spring cleaning Philippe Mathieu-Daudé
2020-05-10 15:28 ` [PATCH 1/7] hw/sparc/sun4m: Use UnimplementedDevice for I/O devices Philippe Mathieu-Daudé
2020-05-10 15:28 ` [PATCH 2/7] hw/misc/empty_slot: Lower address space priority Philippe Mathieu-Daudé
2020-05-10 15:28 ` [PATCH 3/7] hw/misc/empty_slot: Convert 'size' field as qdev property Philippe Mathieu-Daudé
2020-05-10 15:28 ` [PATCH 4/7] hw/misc/empty_slot: Add a 'name' " Philippe Mathieu-Daudé
2020-05-10 15:28 ` [PATCH 5/7] hw/misc/empty_slot: Convert debug printf() to trace event Philippe Mathieu-Daudé
2020-05-10 15:28 ` [PATCH 6/7] hw/misc/empty_slot: Move the 'hw/misc' and cover in MAINTAINERS Philippe Mathieu-Daudé
2020-05-10 15:28 ` [PATCH 7/7] hw/misc/empty_slot: Name the slots when created Philippe Mathieu-Daudé
2020-05-24 16:58 ` Philippe Mathieu-Daudé [this message]
2020-05-24 19:37 ` [PATCH 0/7] hw/misc/empty_slot: Spring cleaning Aleksandar Markovic
2020-05-24 20:21 ` Philippe Mathieu-Daudé
2020-05-24 21:37 ` Peter Maydell
2020-06-08 11:26 ` Artyom Tarasenko
2020-06-09 5:13 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2906ea36-d6c4-f05b-3242-d9380986d48c@redhat.com \
--to=philmd@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).