From: "Cédric Le Goater" <clg@redhat.com>
To: Avihai Horon <avihaih@nvidia.com>, qemu-devel@nongnu.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Joao Martins <joao.m.martins@oracle.com>,
Yishai Hadas <yishaih@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Maor Gottlieb <maorg@nvidia.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
Tarun Gupta <targupta@nvidia.com>
Subject: Re: [PATCH for-8.2 2/6] sysemu: Add pre VM state change callback
Date: Sun, 30 Jul 2023 18:22:09 +0200 [thread overview]
Message-ID: <290ed971-1fe9-c61d-d79c-29d3623aa32d@redhat.com> (raw)
In-Reply-To: <0562c698-3223-005a-e63d-ec94126f0448@nvidia.com>
[ ... ]
>>> + * qemu_add_vm_change_state_handler_prio_full:
>>
>> qemu_add_vm_change_state_handler_prio_all() may be. I don't have much better
>> but 'full' doesn't sound right. minor.
>
> I followed the GLib naming convention.
> For example, g_tree_new and g_tree_new_full, or g_hash_table_new and g_hash_table_new_full.
> I tend to go with GLib naming as it might be more familiar to people.
> What do you think?
Let's keep it then.
Thanks,
C.
next prev parent reply other threads:[~2023-07-30 16:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-16 8:15 [PATCH for-8.2 0/6] vfio/migration: Add P2P support for VFIO migration Avihai Horon
2023-07-16 8:15 ` [PATCH for-8.2 1/6] vfio/migration: Move from STOP_COPY to STOP in vfio_save_cleanup() Avihai Horon
2023-07-30 16:25 ` Cédric Le Goater
2023-07-31 6:32 ` Avihai Horon
2023-07-31 7:05 ` Cédric Le Goater
2023-07-16 8:15 ` [PATCH for-8.2 2/6] sysemu: Add pre VM state change callback Avihai Horon
2023-07-27 16:23 ` Cédric Le Goater
2023-07-30 6:31 ` Avihai Horon
2023-07-30 16:22 ` Cédric Le Goater [this message]
2023-07-16 8:15 ` [PATCH for-8.2 3/6] qdev: Add qdev_add_vm_change_state_handler_full() Avihai Horon
2023-07-16 8:15 ` [PATCH for-8.2 4/6] vfio/migration: Refactor PRE_COPY and RUNNING state checks Avihai Horon
2023-07-21 11:33 ` Cédric Le Goater
2023-07-16 8:15 ` [PATCH for-8.2 5/6] vfio/migration: Add P2P support for VFIO migration Avihai Horon
2023-07-21 11:48 ` Cédric Le Goater
2023-07-23 10:37 ` Avihai Horon
2023-07-16 8:15 ` [PATCH for-8.2 6/6] vfio/migration: Allow migration of multiple P2P supporting devices Avihai Horon
2023-07-21 12:09 ` Cédric Le Goater
2023-07-23 10:42 ` Avihai Horon
2023-07-18 15:46 ` [PATCH for-8.2 0/6] vfio/migration: Add P2P support for VFIO migration Jason Gunthorpe
2023-07-30 6:50 ` Avihai Horon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=290ed971-1fe9-c61d-d79c-29d3623aa32d@redhat.com \
--to=clg@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=avihaih@nvidia.com \
--cc=jgg@nvidia.com \
--cc=joao.m.martins@oracle.com \
--cc=kwankhede@nvidia.com \
--cc=maorg@nvidia.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=targupta@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).