From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: "Cédric Le Goater" <clg@kaod.org>, qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, qemu-ppc@nongnu.org,
david@gibson.dropbear.id.au
Subject: Re: [PATCH v2 0/5] Re-write PPC64 PMU instruction count using TCG Ops
Date: Mon, 3 Jan 2022 15:14:19 -0300 [thread overview]
Message-ID: <29118dc3-2afc-3d4f-595b-22e4b820efef@gmail.com> (raw)
In-Reply-To: <319c406d-0b4b-12aa-0057-ed967c232648@kaod.org>
On 1/3/22 03:46, Cédric Le Goater wrote:
> On 12/23/21 21:18, Daniel Henrique Barboza wrote:
>> Hi,
>>
>> In this version the tedious repetition was taken away from the
>> code by using a helper that increments the PMCs based on specified
>> conditions.
>>
>> As far as Avocado test goes, the performance is the same as the previous
>> version. All PMU-EBB kernel selftests are also passing. Basically we have
>> the same benefits from v1 but 150+ lines shorter.
>>
>> changes from v1:
>> - former patches 2-6: removed
>> - new patch 2:
>> * added inc_spr_if_cond() helper
>> - new patch 3:
>> * add insn count for PMCs 1-4
>> - patch 4 (former 7):
>> * use a loop to reduce code repetition when checking for counter
>> overflows
>> - v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-12/msg03871.html
>
> I understand that you are going to rebase on top of Richard's patchset.
> and so this series is now obsolete ?
Yes it is. I'll post a new version of Richard's patchset shortly.
Daniel
>
> Thanks,
>
> C.
>
prev parent reply other threads:[~2022-01-03 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 20:18 [PATCH v2 0/5] Re-write PPC64 PMU instruction count using TCG Ops Daniel Henrique Barboza
2021-12-23 20:18 ` [PATCH v2 1/5] target/ppc: introduce power8-pmu-insn-cnt.c.inc Daniel Henrique Barboza
2021-12-23 20:18 ` [PATCH v2 2/5] target/ppc/power8-pmu-insn-cnt: introduce inc_spr_if_cond() Daniel Henrique Barboza
2021-12-23 21:14 ` Richard Henderson
2021-12-23 20:18 ` [PATCH v2 3/5] target/ppc/power8-pmu-insn-cnt: add PMCs1-4 insn count Daniel Henrique Barboza
2021-12-23 20:18 ` [PATCH v2 4/5] target/ppc/power8-pmu-insn-cnt: add pmu_check_overflow() Daniel Henrique Barboza
2021-12-23 20:18 ` [PATCH v2 5/5] target/ppc/power8-pmu.c: remove helper_insns_inc() Daniel Henrique Barboza
2022-01-03 6:46 ` [PATCH v2 0/5] Re-write PPC64 PMU instruction count using TCG Ops Cédric Le Goater
2022-01-03 18:14 ` Daniel Henrique Barboza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29118dc3-2afc-3d4f-595b-22e4b820efef@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).