From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HTHFn-0005va-3C for qemu-devel@nongnu.org; Mon, 19 Mar 2007 08:46:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HTHFk-0005p6-HL for qemu-devel@nongnu.org; Mon, 19 Mar 2007 08:46:21 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HTHFk-0005ox-9F for qemu-devel@nongnu.org; Mon, 19 Mar 2007 07:46:20 -0500 Received: from eastrmmtao101.cox.net ([68.230.240.7]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HTHEH-0005Vd-Rh for qemu-devel@nongnu.org; Mon, 19 Mar 2007 08:44:50 -0400 Message-ID: <29133658.1174308289886.JavaMail.root@eastrmwml08.cox.net> Date: Mon, 19 Mar 2007 8:44:49 -0400 From: Ben Taylor Subject: Re: [Qemu-devel] please review this scsi patch MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Reply-To: sol10x86@cox.net, qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: cywang.eda@gmail.com, qemu-devel@nongnu.org ---- Avi Kivity wrote: > Wang Cheng Yeh wrote: > > thanks > > If you include a description of what the patch does and why it is > necessary, it will probably be reviewed a lot quicker. He's posted this one before, and the patch fixes such blatent programming errors like an XOR case option using "|" instead of "^" and a 32-bit write split into 4 byte writes, and passing the third byte twice. Ben