From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crlcF-0001gU-1Y for qemu-devel@nongnu.org; Sat, 25 Mar 2017 09:20:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crlcA-0006fi-Ju for qemu-devel@nongnu.org; Sat, 25 Mar 2017 09:20:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45364) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1crlcA-0006fS-E3 for qemu-devel@nongnu.org; Sat, 25 Mar 2017 09:20:18 -0400 Date: Sat, 25 Mar 2017 06:14:18 -0400 (EDT) From: Paolo Bonzini Message-ID: <291670989.7316919.1490436858720.JavaMail.zimbra@redhat.com> In-Reply-To: References: <20170324220141.10104-1-Andrew.Baumann@microsoft.com> <1173789300.7253222.1490394527808.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] win32: replace custom mutex and condition variable with native primitives List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Baumann Cc: Andrey Shedel , Stefan Weil , qemu-devel@nongnu.org ----- Original Message ----- > From: "Andrew Baumann" > To: "Paolo Bonzini" > Cc: "Andrey Shedel" , "Stefan Weil" , qemu-devel@nongnu.org > Sent: Saturday, March 25, 2017 12:14:20 AM > Subject: Re: [Qemu-devel] [PATCH] win32: replace custom mutex and condition variable with native primitives > > > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > > Sent: Friday, 24 March 2017 15:29 > > > > From: Andrey Shedel > > > > > > The multithreaded TCG implementation exposed deadlocks in the win32 > > > condition variables: as implemented, qemu_cond_broadcast waited on > > > receivers, whereas the pthreads API it was intended to emulate does > > > not. This was causing a deadlock because broadcast was called while > > > holding the IO lock, as well as all possible waiters blocked on the > > > same lock. > > > > > > This patch replaces all the custom synchronisation code for mutexes > > > and condition variables with native Windows primitives (SRWlocks and > > > condition variables) with the same semantics as their POSIX > > > equivalents. To enable that, it requires a Windows Vista or newer host > > > OS. > > > > > > [AB: edited commit message] > > > Signed-off-by: Andrew Baumann > > > > Oops, just a nit but an important one: there should be a > > Signed-off-by for Andrey as well. > > Oops, my fault, since I took his code and prepared the patch submission. We > can resend with the signoff, but perhaps I should wait for a review? It's enough if he replies with the Signed-off-by line. Paolo