Re: [PATCH] Prepare bcm properties for videocore 4

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 30/5/23 15:00, Kambalin, Sergey wrote:
> Got it! Thanks!
> 
> I'll split this one to three patches:
> 1) replace magic numbers with named constants (refactoring)
> 
> 2) add new properties for VC 4
> 
> 3) Add some unit tests to check the newly added properties via mailbox
> 
> 
> Is it OK?

This looks good. Try to imagine sitting on the other side, where
developers will review your code. Usually the simplest the better,
even dumb patches, since there is no risk for doubt. Don't be afraid
to post many small patches.

Personally I'd do:

- import Linux definitions
- replace current magic values with imported Linux defs
- add GET_CLOCKS property
- add GET_THROTTLED property
- add FRAMEBUFFER properties
- add GPIO properties
- add VCHIQ property

Look at do_test_arm_raspi*() in tests/avocado/boot_linux_console.py,
you could add newer kernels which use the properties you added.

> (Sorry for wasting your time by inappropriate patches - this is my first 
> experience with OSS)

So far you are doing great!

Thanks,

Phil.