From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Helge Deller <deller@gmx.de>, Paolo Bonzini <pbonzini@redhat.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH 1/4] hw/net/i82596: Include missing 'exec/address-spaces.h' header
Date: Mon, 19 Jun 2023 10:05:30 +0200 [thread overview]
Message-ID: <2920d8da-4298-82e9-7d41-f00892a03e29@linaro.org> (raw)
In-Reply-To: <20230619074153.44268-2-philmd@linaro.org>
On 6/19/23 09:41, Philippe Mathieu-Daudé wrote:
> hw/net/i82596.c access the global 'address_space_memory'
> calling the ld/st_phys() API. address_space_memory is
> declared in "exec/address-spaces.h". Currently this header
> is indirectly pulled in via another header. Explicitly include
> it to avoid when refactoring unrelated headers:
>
> hw/net/i82596.c:91:23: error: use of undeclared identifier 'address_space_memory'; did you mean 'address_space_destroy'?
> return ldub_phys(&address_space_memory, addr);
> ^~~~~~~~~~~~~~~~~~~~
> address_space_destroy
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> hw/net/i82596.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-06-19 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 7:41 [PATCH 0/4] exec: Header cleanups around memory.h/address-spaces.h Philippe Mathieu-Daudé
2023-06-19 7:41 ` [PATCH 1/4] hw/net/i82596: Include missing 'exec/address-spaces.h' header Philippe Mathieu-Daudé
2023-06-19 8:05 ` Richard Henderson [this message]
2023-06-19 7:41 ` [PATCH 2/4] hw/dma/etraxfs: Include missing 'exec/memory.h' header Philippe Mathieu-Daudé
2023-06-19 8:05 ` Richard Henderson
2023-06-19 7:41 ` [PATCH 3/4] exec/address-spaces.h: Remove unuseful 'exec/memory.h' include Philippe Mathieu-Daudé
2023-06-19 8:06 ` Richard Henderson
2023-06-19 7:41 ` [PATCH 4/4] sysemu/kvm: Re-include "exec/memattrs.h" header Philippe Mathieu-Daudé
2023-06-19 8:06 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2920d8da-4298-82e9-7d41-f00892a03e29@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=edgar.iglesias@gmail.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).