From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bws62-0000l7-L3 for qemu-devel@nongnu.org; Wed, 19 Oct 2016 10:43:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bws5y-0002BC-2T for qemu-devel@nongnu.org; Wed, 19 Oct 2016 10:43:58 -0400 References: <1476879941-14360-1-git-send-email-david@gibson.dropbear.id.au> <1476879941-14360-9-git-send-email-david@gibson.dropbear.id.au> From: Laurent Vivier Message-ID: <2926dace-6ab1-dc32-bcd5-4e2db4ec0100@redhat.com> Date: Wed, 19 Oct 2016 16:43:48 +0200 MIME-Version: 1.0 In-Reply-To: <1476879941-14360-9-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 08/11] tests: Clean up IO handling in ide-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , pbonzini@redhat.com, qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, agraf@suse.de, stefanha@redhat.com, mst@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, groug@kaod.org, thuth@redhat.com On 19/10/2016 14:25, David Gibson wrote: > ide-test uses many explicit inb() / outb() operations for its IO, which > means it's not portable to non-x86 platforms. This cleans it up to use > the libqos PCI accessors instead. > > Signed-off-by: David Gibson > --- > tests/ide-test.c | 179 ++++++++++++++++++++++++++++++++++++------------------- > 1 file changed, 118 insertions(+), 61 deletions(-) Could explain why you have swapped the le16_to_cpu() and cpu_to_le16()? For me, they were correct. Thanks, Laurent