Re: [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'

["Philippe Mathieu-Daudé" <f4bug@amsat.org>]

ping...

On 5/5/20 12:07 PM, Philippe Mathieu-Daudé wrote:
> Use the generic AUDIO_HOST_ENDIANNESS definition instead
> of a custom one.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Who/what machine is using this device anyway?
> ---
>  hw/audio/gus.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/hw/audio/gus.c b/hw/audio/gus.c
> index eb4a803fb5..c8df2bde6b 100644
> --- a/hw/audio/gus.c
> +++ b/hw/audio/gus.c
> @@ -41,12 +41,6 @@
>  #define ldebug(...)
>  #endif
>  
> -#ifdef HOST_WORDS_BIGENDIAN
> -#define GUS_ENDIANNESS 1
> -#else
> -#define GUS_ENDIANNESS 0
> -#endif
> -
>  #define TYPE_GUS "gus"
>  #define GUS(obj) OBJECT_CHECK (GUSState, (obj), TYPE_GUS)
>  
> @@ -256,7 +250,7 @@ static void gus_realizefn (DeviceState *dev, Error **errp)
>      as.freq = s->freq;
>      as.nchannels = 2;
>      as.fmt = AUDIO_FORMAT_S16;
> -    as.endianness = GUS_ENDIANNESS;
> +    as.endianness = AUDIO_HOST_ENDIANNESS;
>  
>      s->voice = AUD_open_out (
>          &s->card,
>