From: Paolo Bonzini <pbonzini@redhat.com>
To: "Stefano Garzarella" <sgarzare@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] checkpatch: avoid error on cover letter files
Date: Fri, 18 Sep 2020 10:06:12 +0200 [thread overview]
Message-ID: <29551205-9aff-07c3-cd13-2b01169029ac@redhat.com> (raw)
In-Reply-To: <20200918070524.kc7y4rbtkuzw2ccl@steredhat>
On 18/09/20 09:05, Stefano Garzarella wrote:
> On Thu, Sep 17, 2020 at 07:44:21PM +0200, Philippe Mathieu-Daudé wrote:
>> On 9/17/20 7:02 PM, Stefano Garzarella wrote:
>>> Running checkpatch on a directory that contains a cover letter reports
>>> this error:
>>>
>>> Checking /tmp/tmpbnngauy3/0000-cover-letter.patch...
>>> ERROR: Does not appear to be a unified-diff format patch
>>>
>>> total: 1 errors, 0 warnings, 0 lines checked
>>>
>>> Let's skip cover letter as it is already done in the Linux kernel.
>>
>> .. "commits 06330fc40e3f ("checkpatch: avoid NOT_UNIFIED_DIFF errors
>> on cover-letter.patch files") and a08ffbef4ab7 ("checkpatch: fix
>> ignoring cover-letter logic")."
>>
>> Maybe complete with that ^^^ ?
>
> Yes, it's better ;-)
>
> Should I send a v2 or can be updated when queueing?
>
>>
>> Regardless:
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Thanks!
>
> Stefano
>
Queued with the fixed message, thanks.
Paolo
prev parent reply other threads:[~2020-09-18 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 17:02 [PATCH] checkpatch: avoid error on cover letter files Stefano Garzarella
2020-09-17 17:44 ` Philippe Mathieu-Daudé
2020-09-18 7:05 ` Stefano Garzarella
2020-09-18 8:06 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29551205-9aff-07c3-cd13-2b01169029ac@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).