From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3391C33CB1 for ; Wed, 15 Jan 2020 14:47:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADA3C214AF for ; Wed, 15 Jan 2020 14:47:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hF6p4K6l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADA3C214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irjwi-0003X9-Q0 for qemu-devel@archiver.kernel.org; Wed, 15 Jan 2020 09:47:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45067) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irjvn-0002t3-Nk for qemu-devel@nongnu.org; Wed, 15 Jan 2020 09:46:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irjvj-0002jB-Od for qemu-devel@nongnu.org; Wed, 15 Jan 2020 09:46:03 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:39940 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1irjvj-0002ik-L9 for qemu-devel@nongnu.org; Wed, 15 Jan 2020 09:45:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579099558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sxHCDVpna5Z29K2SKUl/QkVJIQsRwG7+GMkSYzzXztA=; b=hF6p4K6lrj6YtgsWhFG12ISf6N3Q3wdTEnA3uP8K8zogX+QZuUo7+dAxya162/Cv0bPtl5 oH0bg1G1VGHS6wW7BPU5YP8ioWGACovkW3JBcTsMY2nItuquB/uq3hnmMFcboiR9EK+KbG CLUIZEkIriMS+hEQ6deaoUickj5w8EU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-183-xRAg0qAsOheY4uZJ2wjjWQ-1; Wed, 15 Jan 2020 09:45:56 -0500 Received: by mail-wm1-f70.google.com with SMTP id y125so1559946wmg.1 for ; Wed, 15 Jan 2020 06:45:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eWtdqzuqF0Zj3s1OnmC2RRlGAp3nKqQ5v2wqbGrdqeY=; b=hoY7mzbj5ugW2dSqlqANvaPxSHcY0ZpCSHr/i6MHXjfNTDUAv5r9gileNcWec+ccHe C4qaT0CrR6Aj84M9aa+xLOSlQ0BfvjibE1tCYxr/hzaWdJ2Mv0jJUYQF9kzSqRFf565i 7KMgZJnGTDVQJ5vY7yiMfF8dT/x7f71+PLPQ0FAo/1l0dQtH59hH+gvV/QvO4deEFZBi 9CrWyhvGQwiccsjmHxQMO6bg3E8hrKhOTR+1MgiqO0/mOlKDw7V2g6drIjPvLDgMNmYo h2ugeUqkXo03OkSSKyxg8CucQm4jTrCP4J58J3RudLgK8/dm40xXK7VzcJEY+8sYciSU 2iDg== X-Gm-Message-State: APjAAAWMnGbq4mbuO6dlQAtOU4YpQGMHpSMfKz+gYgSNB/ECs/8Eu4Wx HMaNI0pkBrTf8f59LoyDO+lKH0sQegxZRo+tnqrv4uviiR4pk2VAW7p/PjRPtL8qsGDPRta89J+ 6cbfsN5QX/PNLYhY= X-Received: by 2002:a05:600c:298:: with SMTP id 24mr45758wmk.141.1579099555297; Wed, 15 Jan 2020 06:45:55 -0800 (PST) X-Google-Smtp-Source: APXvYqw7EXKI34oPK5ibvBsPl40wY8r2Ptzf8mPueD6TAsXGLWSHqbvvP6N+gSZihd900AtbPglT8Q== X-Received: by 2002:a05:600c:298:: with SMTP id 24mr45734wmk.141.1579099555094; Wed, 15 Jan 2020 06:45:55 -0800 (PST) Received: from [192.168.1.24] (lfbn-mon-1-1519-115.w92-167.abo.wanadoo.fr. [92.167.83.115]) by smtp.gmail.com with ESMTPSA id k82sm99554wmf.10.2020.01.15.06.45.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jan 2020 06:45:54 -0800 (PST) Subject: Re: [PATCH] hw/input: Do not enable CONFIG_PCKBD by default To: Laurent Vivier , Thomas Huth , qemu-devel@nongnu.org, Paolo Bonzini References: <20200115113748.24757-1-thuth@redhat.com> <670ab2be-d6ba-1eef-fd56-e6f8df7e0085@vivier.eu> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <295c23bb-0849-df2a-1b97-14d257b80aad@redhat.com> Date: Wed, 15 Jan 2020 15:45:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <670ab2be-d6ba-1eef-fd56-e6f8df7e0085@vivier.eu> Content-Language: en-US X-MC-Unique: xRAg0qAsOheY4uZJ2wjjWQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/15/20 12:46 PM, Laurent Vivier wrote: > Le 15/01/2020 =C3=A0 12:37, Thomas Huth a =C3=A9crit=C2=A0: >> The i8042 device is part of the chipset of a machine, so it should >> be selected by the machines or chipsets (e.g. SuperIO chipsets), >> and not be enabled by default. The sentence "The i8042 device is part of the chipset of a machine"=20 sounds odd to me. Maybe simply use "The i8042 PS/2 Controller should not be enabled by=20 default. It has to be selected by machines or chipsets (e.g. SuperIO=20 chipsets)." >> >> Signed-off-by: Thomas Huth >> --- >> hw/input/Kconfig | 1 - >> hw/isa/Kconfig | 1 + >> 2 files changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/input/Kconfig b/hw/input/Kconfig >> index 287f08887b..a2f25725be 100644 >> --- a/hw/input/Kconfig >> +++ b/hw/input/Kconfig >> @@ -7,7 +7,6 @@ config LM832X >> =20 >> config PCKBD >> bool >> - default y >> select PS2 >> depends on ISA_BUS >> =20 >> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig >> index 8a38813cc1..c7f07854f7 100644 >> --- a/hw/isa/Kconfig >> +++ b/hw/isa/Kconfig >> @@ -16,6 +16,7 @@ config I82378 >> config ISA_SUPERIO >> bool >> select ISA_BUS >> + select PCKBD >> =20 >> config PC87312 >> bool >> >=20 > It is also used by R4K but the Kconfig already includes it, so: I believe R4K should 'select ISA_SUPERIO' but we don't have specs and=20 this machine is deprecated, so I didn't bother improving it. >=20 > Reviewed-by: Laurent Vivier >=20 Reviewed-by: Philippe Mathieu-Daud=C3=A9