From: "Zoltán Kővágó" <dirty.ice.hu@gmail.com>
To: "Volker Rümelin" <vr_qemu@t-online.de>,
Programmingkid <programmingkidx@gmail.com>,
"qemu Developers" <qemu-devel@nongnu.org>,
"Howard Spoelstra" <hsp.cat7@gmail.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2] Implement the Screamer sound chip for the mac99 machine type
Date: Sun, 2 Feb 2020 20:47:02 +0100 [thread overview]
Message-ID: <295dbdec-2ad3-d5ac-4ad6-a590f3be98ba@gmail.com> (raw)
In-Reply-To: <5314e860-dffe-3bc0-209f-bd2b937cd0c6@t-online.de>
On 2020-01-28 09:30, Volker Rümelin wrote:
>> Hi,
>>
>> Unfortunately it's not that simple to simply revert the patch since the old backend api no longer exists. Also I don't have a Mac so it's almost impossible for me to test the results. I looked at the specified commit and I think I found a problem, could you please apply the attached patch on the current git master and check whether it solves the problem? If yes I'll turn it into a proper patch.
>>
>> Regards,
>> Zoltan
>>
>
> Hi Zoltán,
>
> I also don't have a Mac so I tested your patch with a slightly modified sdlaudio version. I found two bugs in your patch. With the bugs fixed I have working SDL2 audio playback with float type samples. Now I wonder if the fixed patch also fixes coreaudio playback. Depending on how busy you are I can just write a review for your patch and let you handle the rest, or may I send a modified version of your patch to the mailing list for testing?
>
> With best regards
> Volker
Hi,
Maybe I'm a bit late since you already did it, but go ahead, I don't
have too much time to work on qemu recently.
Regards,
Zoltan
next prev parent reply other threads:[~2020-02-02 19:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 1:58 [PATCH v2] Implement the Screamer sound chip for the mac99 machine type Programmingkid
2020-01-05 14:39 ` Programmingkid
2020-01-11 0:32 ` Zoltán Kővágó
2020-01-11 0:59 ` Programmingkid
2020-01-28 8:30 ` Volker Rümelin
2020-01-28 9:38 ` Howard Spoelstra
2020-01-29 7:09 ` Volker Rümelin
2020-01-29 7:13 ` [RFC] coreaudio: fix coreaudio_test.diff Volker Rümelin
2020-01-30 15:03 ` Howard Spoelstra
2020-01-31 7:37 ` Volker Rümelin
2020-01-31 8:03 ` Gerd Hoffmann
2020-01-31 8:35 ` Mark Cave-Ayland
2020-01-31 9:12 ` Howard Spoelstra
2020-01-31 15:55 ` Programmingkid
2020-02-02 19:47 ` Zoltán Kővágó [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-29 2:45 [PATCH v2] Implement the Screamer sound chip for the mac99 machine type John Arbuckle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=295dbdec-2ad3-d5ac-4ad6-a590f3be98ba@gmail.com \
--to=dirty.ice.hu@gmail.com \
--cc=hsp.cat7@gmail.com \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).