From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: Eric Blake <eblake@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
qemu block <qemu-block@nongnu.org>,
"nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>
Subject: Re: [Qemu-devel] [PATCH v4 04/11] nbd: Improve server handling of bogus commands
Date: Wed, 15 Jun 2016 00:05:18 +0200 [thread overview]
Message-ID: <2967191c-0204-f99c-0dca-169cdfbcc419@redhat.com> (raw)
In-Reply-To: <B82C8FF7-FB05-4B46-BCEE-A6C41CBA0C45@alex.org.uk>
On 14/06/2016 17:59, Alex Bligh wrote:
>
>> On 14 Jun 2016, at 16:11, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>>> To illustrate the problem, look consider what qemu itself would do as
>>> a server if it can't buffer the entire read issued to it.
>>
>> Return ENOMEM?
>
> Well OK, qemu then 'works' on the basis it breaks another
> part of the spec, which is coping with long reads.
ENOMEM is a documented error code, and the limits extension will help
with that as well.
>> However, it looks like the
>> de facto status prior to structured replies is that the error is in the
>> spec, and this patch introduces a regression.
>
> Well, I guess the patch makes it work the same as the
> reference server implementation and the spec, which I'd
> consider a fix. My view is that the error is in the
> kernel client.
... and QEMU and BSD. What good is a server that doesn't interoperate
(albeit only in error cases) with any client?
Paolo
next prev parent reply other threads:[~2016-06-14 22:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 22:39 [Qemu-devel] [PATCH v4 00/11] nbd: tighter protocol compliance Eric Blake
2016-05-11 22:39 ` [Qemu-devel] [PATCH v4 01/11] nbd: Use BDRV_REQ_FUA for better FUA where supported Eric Blake
2016-05-11 22:39 ` [Qemu-devel] [PATCH v4 02/11] nbd: More debug typo fixes, use correct formats Eric Blake
2016-06-13 12:04 ` Paolo Bonzini
2016-06-13 12:21 ` Eric Blake
2016-05-11 22:39 ` [Qemu-devel] [PATCH v4 03/11] nbd: Quit server after any write error Eric Blake
2016-05-11 22:39 ` [Qemu-devel] [PATCH v4 04/11] nbd: Improve server handling of bogus commands Eric Blake
2016-06-13 12:10 ` Paolo Bonzini
2016-06-13 12:25 ` Eric Blake
2016-06-13 21:41 ` Alex Bligh
2016-06-14 13:32 ` Paolo Bonzini
2016-06-14 15:02 ` Alex Bligh
2016-06-14 15:11 ` Paolo Bonzini
2016-06-14 15:59 ` Alex Bligh
2016-06-14 22:05 ` Paolo Bonzini [this message]
2016-06-15 7:05 ` [Qemu-devel] [Nbd] " Wouter Verhelst
2016-06-15 8:03 ` Wouter Verhelst
2016-06-15 8:52 ` Alex Bligh
2016-06-15 9:18 ` Paolo Bonzini
2016-06-15 10:27 ` Alex Bligh
2016-06-15 10:34 ` Paolo Bonzini
2016-06-15 12:13 ` Wouter Verhelst
2016-06-15 7:02 ` Wouter Verhelst
2016-06-13 12:19 ` [Qemu-devel] " Paolo Bonzini
2016-06-13 16:54 ` Eric Blake
2016-06-14 18:24 ` Eric Blake
2016-05-11 22:39 ` [Qemu-devel] [PATCH v4 05/11] nbd: Reject unknown request flags Eric Blake
2016-05-11 22:39 ` [Qemu-devel] [PATCH v4 06/11] nbd: Group all Linux-specific ioctl code in one place Eric Blake
2016-05-11 22:39 ` [Qemu-devel] [PATCH v4 07/11] nbd: Clean up ioctl handling of qemu-nbd -c Eric Blake
2016-05-11 22:39 ` [Qemu-devel] [PATCH v4 08/11] nbd: Limit nbdflags to 16 bits Eric Blake
2016-05-11 22:39 ` [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readable description Eric Blake
2016-05-12 7:47 ` Daniel P. Berrange
2016-05-12 15:38 ` Eric Blake
2016-05-12 15:51 ` Daniel P. Berrange
2016-05-11 22:39 ` [Qemu-devel] [PATCH v4 10/11] nbd: Detect servers that send unexpected error values Eric Blake
2016-05-11 22:39 ` [Qemu-devel] [PATCH v4 11/11] nbd: Avoid magic number for NBD max name size Eric Blake
2016-05-12 16:04 ` [Qemu-devel] [PATCH v4 00/11] nbd: tighter protocol compliance Alex Bligh
2016-06-01 23:02 ` Eric Blake
2016-06-13 16:28 ` Paolo Bonzini
2016-06-13 16:49 ` Eric Blake
2016-06-14 16:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2967191c-0204-f99c-0dca-169cdfbcc419@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex@alex.org.uk \
--cc=eblake@redhat.com \
--cc=nbd-general@lists.sourceforge.net \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).