From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 1/4] util/qemu-timer: Make timer_free() imply timer_del()
Date: Tue, 15 Dec 2020 09:54:11 -0600 [thread overview]
Message-ID: <2982d998-408b-1bcd-fbf8-d55df871f305@linaro.org> (raw)
In-Reply-To: <20201215154107.3255-2-peter.maydell@linaro.org>
On 12/15/20 9:41 AM, Peter Maydell wrote:
> +static inline void timer_free(QEMUTimer *ts)
> +{
> +
> + timer_del(ts);
Extra whitespace. Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-12-15 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 15:41 [PATCH v2 0/4] qemu-timer: Make timer_free() imply timer_del() Peter Maydell
2020-12-15 15:41 ` [PATCH v2 1/4] util/qemu-timer: " Peter Maydell
2020-12-15 15:54 ` Richard Henderson [this message]
2020-12-15 15:41 ` [PATCH v2 2/4] scripts/coccinelle: New script to remove unnecessary timer_del() calls Peter Maydell
2020-12-15 15:55 ` Richard Henderson
2020-12-15 15:41 ` [PATCH v2 3/4] Remove superfluous " Peter Maydell
2020-12-15 15:41 ` [PATCH v2 4/4] target/arm: Remove timer_del()/timer_deinit() before timer_free() Peter Maydell
2020-12-15 15:54 ` Richard Henderson
2021-01-05 10:54 ` [PATCH v2 0/4] qemu-timer: Make timer_free() imply timer_del() Philippe Mathieu-Daudé
2021-01-07 21:18 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2982d998-408b-1bcd-fbf8-d55df871f305@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).