From: Laszlo Ersek <lersek@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com, "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com, dme@dme.org
Subject: Re: [PATCH v3 2/2] pci: add romsize property
Date: Wed, 3 Feb 2021 20:14:40 +0100 [thread overview]
Message-ID: <2982e16b-7a92-6dd7-ae34-4dcb5291c7f0@redhat.com> (raw)
In-Reply-To: <20210203131828.156467-3-pbonzini@redhat.com>
On 02/03/21 14:18, Paolo Bonzini wrote:
> This property can be useful for distros to set up known-good ROM sizes for
> migration purposes. The VM will fail to start if the ROM is too large,
> and migration compatibility will not be broken if the ROM is too small.
>
> Note that even though romsize is a uint32_t, it has to be between 1
> (because empty ROM files are not accepted, and romsize must be greater
> than the file) and 2^31 (because values above are not powers of two and
> are rejected).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Message-Id: <20201218182736.1634344-1-pbonzini@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/pci/pci.c | 19 +++++++++++++++++--
> hw/xen/xen_pt_load_rom.c | 14 ++++++++++++--
> include/hw/pci/pci.h | 1 +
> 3 files changed, 30 insertions(+), 4 deletions(-)
Acked-by: Laszlo Ersek <lersek@redhat.com>
prev parent reply other threads:[~2021-02-03 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 13:18 [PATCH v3 0/2] pci: add romsize property Paolo Bonzini
2021-02-03 13:18 ` [PATCH v3 1/2] pci: reject too large ROMs Paolo Bonzini
2021-02-03 14:08 ` David Edmondson
2021-02-03 13:18 ` [PATCH v3 2/2] pci: add romsize property Paolo Bonzini
2021-02-03 14:08 ` David Edmondson
2021-02-03 19:14 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2982e16b-7a92-6dd7-ae34-4dcb5291c7f0@redhat.com \
--to=lersek@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dme@dme.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).