Re: [PATCH v9 5/5] amd_iommu: report x2APIC support to the operating system

[Bui Quang Minh <minhquangbui99@gmail.com>]

On 11/9/23 02:44, Michael S. Tsirkin wrote:
> On Wed, Nov 08, 2023 at 09:22:18PM +0700, Bui Quang Minh wrote:
>> On 11/7/23 07:39, Michael S. Tsirkin wrote:
>>> On Tue, Oct 24, 2023 at 10:21:05PM +0700, Bui Quang Minh wrote:
>>>> This commit adds XTSup configuration to let user choose to whether enable
>>>> this feature or not. When XTSup is enabled, additional bytes in IRTE with
>>>> enabled guest virtual VAPIC are used to support 32-bit destination id.
>>>>
>>>> Additionally, this commit exports IVHD type 0x11 besides the old IVHD type
>>>> 0x10 in ACPI table. IVHD type 0x10 does not report full set of IOMMU
>>>> features only the legacy ones, so operating system (e.g. Linux) may only
>>>> detects x2APIC support if IVHD type 0x11 is available. The IVHD type 0x10
>>>> is kept so that old operating system that only parses type 0x10 can detect
>>>> the IOMMU device.
>>>>
>>>> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>>>> Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
>>>
>>>
>>> changes IVRS without updating expected files for tests.
>>> result seems to be CI failures:
>>> https://gitlab.com/mstredhat/qemu/-/jobs/5470533834
>>
>>
>> Thanks Michael, I am preparing the fix in the next version. I've read the
>> instructions to update the test data in bios-tables-test.c. It says I need
>> to create some separate patches to update the test data. Are there any
>> reasons for this? I intend to change the binary and include the ASL diff
>> into the commit message. Is it enough?
> 
> No, not enough.  No, do not ignore the rules please.  Yes, there's a
> reason.  The reason is that I need to be able to rebase your patches.  I
> then regenerate the binaries. If the patch includes binaries it won't
> rebase.

Okay, I got it. I will prepare the fix in the next version.

Thanks,
Quang Minh.