Re: [PATCH 04/28] cpus: Restrict cpu_get_memory_mapping() to system emulation

[Richard Henderson <richard.henderson@linaro.org>]

On 1/21/25 06:23, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/hw/core/cpu.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
> index b7367f6d808..2402706c7d9 100644
> --- a/include/hw/core/cpu.h
> +++ b/include/hw/core/cpu.h
> @@ -614,6 +614,8 @@ extern bool mttcg_enabled;
>    */
>   bool cpu_paging_enabled(const CPUState *cpu);
>   
> +#if !defined(CONFIG_USER_ONLY)
> +
>   /**
>    * cpu_get_memory_mapping:
>    * @cpu: The CPU whose memory mappings are to be obtained.
> @@ -625,8 +627,6 @@ bool cpu_paging_enabled(const CPUState *cpu);
>   bool cpu_get_memory_mapping(CPUState *cpu, MemoryMappingList *list,
>                               Error **errp);
>   
> -#if !defined(CONFIG_USER_ONLY)
> -
>   /**
>    * cpu_write_elf64_note:
>    * @f: pointer to a function that writes memory to a file

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~