From: Thomas Huth <thuth@redhat.com>
To: "Lucas Mateus Castro(alqotel)" <lucas.araujo@eldorado.org.br>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Cleber Rosa <crosa@redhat.com>
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>
Subject: Re: [PATCH v2 1/4] scripts/ci/setup: ninja missing from build-environment
Date: Thu, 15 Sep 2022 16:54:17 +0100 [thread overview]
Message-ID: <29bfc681-0e37-e799-85fa-bf8ed0d096eb@redhat.com> (raw)
In-Reply-To: <20220914124153.61017-2-lucas.araujo@eldorado.org.br>
On 14/09/2022 13.41, Lucas Mateus Castro(alqotel) wrote:
> From: "Lucas Mateus Castro (alqotel)" <lucas.araujo@eldorado.org.br>
>
> ninja-build is missing from the RHEL environment, so a system prepared
> with that script would still fail to compile QEMU.
> Tested on a Fedora 36
>
> Signed-off-by: Lucas Mateus Castro (alqotel) <lucas.araujo@eldorado.org.br>
> ---
> scripts/ci/setup/build-environment.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-environment.yml
> index 232525b91d..6df3e61d94 100644
> --- a/scripts/ci/setup/build-environment.yml
> +++ b/scripts/ci/setup/build-environment.yml
> @@ -150,6 +150,7 @@
> - libepoxy-devel
> - libgcrypt-devel
> - lzo-devel
> + - ninja-build
> - make
> - mesa-libEGL-devel
> - nettle-devel
Looks like the list used to be sorted alphabetically, so maybe you should
sort it in some lines later?
And I wonder why this hasn't been noticed before ... Cleber, was this in use
after all?
Thomas
next prev parent reply other threads:[~2022-09-15 15:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 12:41 [PATCH v2 0/4] Patch series to set up a ppc64le CI Lucas Mateus Castro(alqotel)
2022-09-14 12:41 ` [PATCH v2 1/4] scripts/ci/setup: ninja missing from build-environment Lucas Mateus Castro(alqotel)
2022-09-15 15:54 ` Thomas Huth [this message]
2022-09-21 12:09 ` Lucas Mateus Martins Araujo e Castro
2022-09-14 12:41 ` [PATCH v2 2/4] scripts/ci/setup: Fix libxen requirements Lucas Mateus Castro(alqotel)
2022-09-17 21:39 ` Philippe Mathieu-Daudé via
2022-09-14 12:41 ` [PATCH v2 3/4] scripts/ci/setup: spice-server only on x86 aarch64 Lucas Mateus Castro(alqotel)
2022-09-17 21:40 ` Philippe Mathieu-Daudé via
2022-09-14 12:41 ` [PATCH v2 4/4] tests/docker: run script use realpath instead of readlink Lucas Mateus Castro(alqotel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29bfc681-0e37-e799-85fa-bf8ed0d096eb@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=danielhb413@gmail.com \
--cc=lucas.araujo@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).