From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6ACD9C76196 for ; Tue, 28 Mar 2023 13:33:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ph9S6-00037n-Sc; Tue, 28 Mar 2023 09:33:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ph9S1-00037D-P1 for qemu-devel@nongnu.org; Tue, 28 Mar 2023 09:33:26 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ph9Rx-0006S1-NE for qemu-devel@nongnu.org; Tue, 28 Mar 2023 09:33:24 -0400 Received: by mail-wm1-x32b.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso9464036wmb.0 for ; Tue, 28 Mar 2023 06:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680010400; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h5ikHw9oQeGXvYWIgvfLco77jNX5liK4WDNFDFQGFdM=; b=YKOoqLsONv7TvbsBNkqnKMDJzIFU3fPljIlfFcchML34r87mTAYmF0THCxhpWuEJg7 lercR40TbGeEwFAeYWvYx5z8zsvUyBefivkbmX9Fx46uhIh3nbnrNTQNduvOqfXSbmZJ T9E4tEY/cBO35wG0gQuzuMzV+3PKUliT2GbqE/4JaatANChK/UsJZYPUFNl/+Q3Ph4og e70ZSnC83/whk0rbamwNJYL6ZhIDnJ07zZo8bMsDs8pIXrqd3Xb+7I3gP1PUfZ4a0RfZ 4690rilpbJRXejXyjQcICfg56gAstI7Kayl7+30r93LXFkx8HA5S+957qFKxi/mXq4yJ XOdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680010400; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h5ikHw9oQeGXvYWIgvfLco77jNX5liK4WDNFDFQGFdM=; b=RUbhgbLKqNYOkZOuezQ//cvobYzwVczkL1bABRAvw3X14Enab+VXCOvWtgZJn3T7s3 w0G++KjoV2d/ZIkn/R/OUh6E3ZpVOMKNjwKtKXjGk/rwmn9FXuHMaBSwRkp7Q0WNBQTo VKAJOQ0EiNR3x7o2kHUSsr/nvKfcLIu6zQfp5xR8fqn+JRJTTOu1bAAK3560U4XT+Ggm CQgPyYdOKb0ObAx2FtQRkAR+oVveR3eVhnPHdvkM52GTJDI5g5A+p26My17TmldnzxbB 5AU24819gMxeRBcCH3Y7Arqgkx9tko5/dhm+B9Bgzl1K7xldK1Jmyk9QbSNUvegJ0DQT aI5g== X-Gm-Message-State: AO0yUKXqvX1KSNQVrBUBl1I//sdZn+vKZpURCdZ7F8sbwxwuyrdLbucy No2C+jURmlNNPUBZgl6XzJghJw== X-Google-Smtp-Source: AK7set8EupTucYaSgmZpUsbrScBMGf7cu4NlVC6IrJjcuSyAeAgIPLPVM/g5morE0dKQZjBzW29XGA== X-Received: by 2002:a7b:c38a:0:b0:3ed:276d:81a4 with SMTP id s10-20020a7bc38a000000b003ed276d81a4mr12607295wmj.32.1680010400035; Tue, 28 Mar 2023 06:33:20 -0700 (PDT) Received: from [192.168.69.115] ([176.187.210.212]) by smtp.gmail.com with ESMTPSA id z6-20020a05600c0a0600b003ee6aa4e6a9sm12807685wmp.5.2023.03.28.06.33.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 06:33:19 -0700 (PDT) Message-ID: <29d10da0-821d-07c4-16c5-a1f5e2384d3d@linaro.org> Date: Tue, 28 Mar 2023 15:33:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH-for-8.0 0/2] target/arm/gdbstub: Fix builds when TCG is disabled Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Peter Maydell Cc: qemu-devel@nongnu.org, Richard Henderson , Fabiano Rosas , Claudio Fontana , qemu-arm@nongnu.org References: <20230322142902.69511-1-philmd@linaro.org> <958c4810-e351-04e4-42f4-d1bc86d303ad@linaro.org> In-Reply-To: <958c4810-e351-04e4-42f4-d1bc86d303ad@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 28/3/23 15:20, Philippe Mathieu-Daudé wrote: > On 28/3/23 11:54, Peter Maydell wrote: >> On Wed, 22 Mar 2023 at 14:29, Philippe Mathieu-Daudé >> wrote: >>> >>> Fix when building QEMU configured with --disable-tcg: >>> >>>    Undefined symbols for architecture arm64: >>>      "_arm_v7m_get_sp_ptr", referenced from: >>>          _m_sysreg_get in target_arm_gdbstub.c.o >>>      "_arm_v7m_mrs_control", referenced from: >>>          _arm_gdb_get_m_systemreg in target_arm_gdbstub.c.o >>>      "_pauth_ptr_mask", referenced from: >>>          _aarch64_gdb_get_pauth_reg in target_arm_gdbstub64.c.o >>>    ld: symbol(s) not found for architecture arm64 >>>    clang: error: linker command failed with exit code 1 (use -v to >>> see invocation) >>> >>> Philippe Mathieu-Daudé (2): >>>    target/arm/gdbstub: Restrict aarch64_gdb_get_pauth_reg() to >>> CONFIG_TCG >>>    target/arm/gdbstub: Only advertise M-profile features if TCG >>> available >> >> I've applied patch 2 to target-arm.next; thanks. > > If you only take #2, then you need to squash this from #1: > > -- >8 -- > diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c > @@ -21,6 +21,7 @@ >  #include "cpu.h" >  #include "exec/gdbstub.h" >  #include "gdbstub/helpers.h" > +#include "sysemu/tcg.h" >  #include "internals.h" >  #include "cpregs.h" > --- > > I can respin if it eases your workflow. Posted as: https://lore.kernel.org/qemu-devel/20230328133054.6553-2-philmd@linaro.org/ Along with rth's suggestion as another patch.