From: "Annie.li" <annie.li@oracle.com>
To: Viktor Prutyanov <viktor@daynix.com>,
pbonzini@redhat.com, peter.maydell@linaro.org
Cc: viktor.prutyanov@phystech.edu, yuri.benditovich@daynix.com,
yan@daynix.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 0/3] contrib/elf2dmp: Windows Server 2022 support
Date: Mon, 6 Mar 2023 16:35:36 -0500 [thread overview]
Message-ID: <29e7b48c-57ab-f88a-2ff9-404be6526eed@oracle.com> (raw)
In-Reply-To: <20230222211246.883679-1-viktor@daynix.com>
Hello Viktor,
This patch set looks good to me, thank you!
On 2/22/2023 4:12 PM, Viktor Prutyanov wrote:
> Hi,
>
> For now, elf2dmp is unable to convert ELF-dump to DMP-dump made of
> Windows Server 2022 guest. This patch series fixes it.
>
> v1: improve code-style fix
> v2: don't remove data directory entry RVA print and DOS header size check
Reviewed-by: Annie Li <annie.li@oracle.com>
Thanks
Annie
>
> Viktor Prutyanov (3):
> contrib/elf2dmp: fix code style
> contrib/elf2dmp: move PE dir search to pe_get_data_dir_entry
> contrib/elf2dmp: add PE name check and Windows Server 2022 support
>
> contrib/elf2dmp/addrspace.c | 1 +
> contrib/elf2dmp/main.c | 108 ++++++++++++++++++++++-----------
> contrib/elf2dmp/pe.h | 115 ++++++++++++++++++++----------------
> 3 files changed, 140 insertions(+), 84 deletions(-)
>
next prev parent reply other threads:[~2023-03-06 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 21:12 [PATCH v2 0/3] contrib/elf2dmp: Windows Server 2022 support Viktor Prutyanov
2023-02-22 21:12 ` [PATCH v2 1/3] contrib/elf2dmp: fix code style Viktor Prutyanov
2023-02-22 21:12 ` [PATCH v2 2/3] contrib/elf2dmp: move PE dir search to pe_get_data_dir_entry Viktor Prutyanov
2023-02-22 21:12 ` [PATCH v2 3/3] contrib/elf2dmp: add PE name check and Windows Server 2022 support Viktor Prutyanov
2023-03-06 21:35 ` Annie.li [this message]
2023-03-16 16:48 ` [PATCH v2 0/3] contrib/elf2dmp: " Viktor Prutyanov
2023-03-17 13:45 ` Peter Maydell
2023-03-17 15:21 ` Viktor Prutyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29e7b48c-57ab-f88a-2ff9-404be6526eed@oracle.com \
--to=annie.li@oracle.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=viktor.prutyanov@phystech.edu \
--cc=viktor@daynix.com \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).