From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBF5C433E6 for ; Tue, 23 Feb 2021 16:43:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47AAC64E61 for ; Tue, 23 Feb 2021 16:43:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47AAC64E61 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEamj-0003sD-Dt for qemu-devel@archiver.kernel.org; Tue, 23 Feb 2021 11:43:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEakw-0003LF-BY for qemu-devel@nongnu.org; Tue, 23 Feb 2021 11:41:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:29985) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEaku-0003eb-1e for qemu-devel@nongnu.org; Tue, 23 Feb 2021 11:41:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614098507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=acwH2HOPj1JfsMhvPGLoxYmtclLSfFGD9IFCY2B87fc=; b=K+8K8TEaJEwyW2BzJJz98gYd5vask1MQvFpX2rRS2PiMnOB6N5ASR5FcCe7I9e6EV4aaAk sC26gdNvhnd5EIQmIXmjh3BCPZz4HJEb8eazrCVIBDNkbLiPALg52C8aGFJ6Wl8mlaCs73 JyQ0dUNBT3DzyR24RTedZluiAmLNnfo= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-Ix5mHu3ANFOJCFhPgRkV2A-1; Tue, 23 Feb 2021 11:41:43 -0500 X-MC-Unique: Ix5mHu3ANFOJCFhPgRkV2A-1 Received: by mail-ed1-f72.google.com with SMTP id ch30so5106504edb.14 for ; Tue, 23 Feb 2021 08:41:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=acwH2HOPj1JfsMhvPGLoxYmtclLSfFGD9IFCY2B87fc=; b=kB+Np5TsIwsWVj1nFBt5wD9kJA3ZmaeFp99/wmaCezUTTh2Eduu5t125aEJ9VSG5ic d8L3eHqYGt+enymCpZ3Uw0hZ69hOSNpY8QBlpqM8mvnmjg1Bt/A/+ntJ2VNJgNW6OjT5 nM5w8RxeVBdImKAcleixFbdpvoenmSQXT7S8YVQIYCILBmPiH95j5c0JaV+RpqElxosJ KcKzZTT4iIvEOiMP78owXSt56im0dntl6wfis7XqgznCCCF/+q9cU5KD9wf5w4o6ZiYY duQ/1yT9MiIpgsbQxRXgT/ArVZEtGZdDS0Sv8FIwcF2g/ceRJcHtZDtx4yeoFbhIgZib fzAQ== X-Gm-Message-State: AOAM533e6QMJzAXEP5QjWbCR7eeB9tR8gzQfxazeAKpsDuy4ucFp+u0S spS5NEEAkF7YXfD1a619Da2RbDgjsC/tzlDDHe7SvMF+R94Z03/cXB7DUicqtvcufzZFKKFxpxV 9r26Wfv9gXMtulAU= X-Received: by 2002:aa7:c312:: with SMTP id l18mr28579217edq.278.1614098502534; Tue, 23 Feb 2021 08:41:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJysJuw+QONPvK3151iAWy2n20MobyPBj4LcztQI08+h8rnHiHGgXTKOu3bb+YMYv/Mezz73KQ== X-Received: by 2002:aa7:c312:: with SMTP id l18mr28579181edq.278.1614098502276; Tue, 23 Feb 2021 08:41:42 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id br22sm3444132ejb.117.2021.02.23.08.41.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Feb 2021 08:41:41 -0800 (PST) Subject: Re: [PATCH v5 4/4] Jobs based on custom runners: add job definitions for QEMU's machines To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20210219215838.752547-1-crosa@redhat.com> <20210219215838.752547-5-crosa@redhat.com> <21f882ba-21db-2d45-0e74-be27e1119355@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <29f877c0-c6bf-a0f5-968a-51be00c88523@redhat.com> Date: Tue, 23 Feb 2021 17:41:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Thomas Huth , Eduardo Habkost , Erik Skultety , Stefan Hajnoczi , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Andrea Bolognani , Willian Rampazzo , Cleber Rosa , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Beraldo Leal Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/23/21 4:56 PM, Daniel P. Berrangé wrote: > On Tue, Feb 23, 2021 at 04:17:23PM +0100, Philippe Mathieu-Daudé wrote: >> On 2/19/21 10:58 PM, Cleber Rosa wrote: >>> The QEMU project has two machines (aarch64 and s390x) that can be used >>> for jobs that do build and run tests. This introduces those jobs, >>> which are a mapping of custom scripts used for the same purpose. >>> >>> Signed-off-by: Cleber Rosa >>> Reviewed-by: Daniel P. Berrangé >>> --- >>> .gitlab-ci.d/custom-runners.yml | 204 ++++++++++++++++++++++++++++++++ >>> 1 file changed, 204 insertions(+) >>> >>> diff --git a/.gitlab-ci.d/custom-runners.yml b/.gitlab-ci.d/custom-runners.yml >>> index 3004da2bda..a9166c82a2 100644 >>> --- a/.gitlab-ci.d/custom-runners.yml >>> +++ b/.gitlab-ci.d/custom-runners.yml >>> @@ -12,3 +12,207 @@ >>> # strategy. >>> variables: >>> GIT_SUBMODULE_STRATEGY: recursive >>> + >>> +# All ubuntu-18.04 jobs should run successfully in an environment >>> +# setup by the scripts/ci/setup/build-environment.yml task >>> +# "Install basic packages to build QEMU on Ubuntu 18.04/20.04" >>> +ubuntu-18.04-s390x-all-linux-static: >>> + allow_failure: true >>> + needs: [] >>> + stage: build >>> + tags: >>> + - ubuntu_18.04 >>> + - s390x >> >> Where is this tag list filled upon registration? >> >>> + rules: >>> + - if: '$CI_COMMIT_BRANCH =~ /^staging/' >>> + script: >>> + # --disable-libssh is needed because of https://bugs.launchpad.net/qemu/+bug/1838763 >>> + # --disable-glusterfs is needed because there's no static version of those libs in distro supplied packages >>> + - mkdir build >>> + - cd build >>> + - ../configure --enable-debug --static --disable-system --disable-glusterfs --disable-libssh >>> + - make --output-sync -j`nproc` >>> + - make --output-sync -j`nproc` check V=1 >>> + - make --output-sync -j`nproc` check-tcg V=1 >> >> Also this break the rest of the tests... >> >> The first containers job (amd64-alpine-container) got >> added to the custom runner and failed (because docker-dind >> isn't there?): > > Urgh, well that's a big problem. We certainly don't want *anything* being > placed on the custom runners without explicit opt-in, otherwise jobs run > in the main repo have a different environment from when users run on their > personal forks. > > IOW, we need anti-affinity against our custom runners really. > >> $ export TAG="$CI_REGISTRY_IMAGE/qemu/$NAME:latest" >> $ export COMMON_TAG="$CI_REGISTRY/qemu-project/qemu/$NAME:latest" >> $ apk add python3 >> bash: line 110: apk: command not found >> Running after_script 00:01 >> Running after script... >> $ docker logout >> Removing login credentials for https://index.docker.io/v1/ >> ERROR: Job failed: exit status 1 >> >> Do we need to restrict the other jobs to the Gitlab public >> (x86) runners? Maybe as: >> >> diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml >> @@ -1,6 +1,6 @@ >> .container_job_template: &container_job_definition >> + tags: >> + - gitlab-org-docker > > Is that a real tag that exists on gitlab's shared runners, or something > you just invented ? This is not standardized yet: https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/5420 I checked the available runners, some have 'docker' while other have 'gitlab-org-docker'. There are more 'gitlab-org-docker' than 'docker' runners. The tag selection is not exclusive, this is a "all or nothing" selection, so for my testing I choose 'gitlab-org-docker' which is the most available. > >> image: docker:stable >> stage: containers >> services: >> >> Daniel, you didn't hit this problem on the previous version >> of this series? > > I didn't try actually executing previous postings of this series. > > > Regards, > Daniel >