From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A8D7C4741F for ; Mon, 28 Sep 2020 11:44:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B9382100A for ; Mon, 28 Sep 2020 11:44:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cCPu77Wd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B9382100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMrZg-0000cd-Iu for qemu-devel@archiver.kernel.org; Mon, 28 Sep 2020 07:44:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMrXV-00083Z-W4 for qemu-devel@nongnu.org; Mon, 28 Sep 2020 07:41:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kMrXO-0006k2-Gx for qemu-devel@nongnu.org; Mon, 28 Sep 2020 07:41:52 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601293304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vdQoR+osslZnXPOw7kSIBRMlJy0YvjvXkcKF3982mzY=; b=cCPu77Wd5mQ9Sq50fV4N2Bw/2a35G2nfJAcWYNhJWikv/mjc7YF44bgtkMPKfQ81OBN8wk y/SoV9890hxZNasMoqQpOPjKBaVUHys/I93LbPHQGoAwWatzeqfdM84JfobCxK4eewrv+d PM8g8APygo9w1Sask/CJJqrB1C7970w= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-I9lWtr5gPoOLcdMNgT6bWA-1; Mon, 28 Sep 2020 07:41:43 -0400 X-MC-Unique: I9lWtr5gPoOLcdMNgT6bWA-1 Received: by mail-wm1-f70.google.com with SMTP id p20so260605wmg.0 for ; Mon, 28 Sep 2020 04:41:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=vdQoR+osslZnXPOw7kSIBRMlJy0YvjvXkcKF3982mzY=; b=buFg34530d9wtCk7b00PQjb2zBgCjDkvDx4NeJvJLhf790b2idST7LmKGIG6cmt7in QBlfr/Bbs+ufKFRkBI6WxECeyeh133n4By2fyOgHKob46NwZPYujrIloszPn2HIHL5uZ YmE0EyEY848qb8CAWepvr0aR3WyOY5CugMjC9bKYhrJWub6f3DCjFCjTICKrEoM1BSuP 412D2FoaVlDQ9aNRsA85PkmhPdL0PZKgFvUJ13uy3O1Q9oafHw3Vpzc/9KhSVrwqwo3m YPRNyg9eCxu2WtuVYviWVBdhnZbHouPMrw5FSJ3TU0Gjs+HpQFqGTQuDshXG2DjYVMGh WSpA== X-Gm-Message-State: AOAM530a8Z9Z9T5erju2usJbLqtDIGD0S3vTZRNiPHIhCWodsz19//Uz 7zjW1rmPr6cJxBor1JUNH8Ako6TS874PmZaRVLo0dQmGj1x22QBjS58jmSLFEQ8DDjTLZjmVb9I SrpXofJsaOnid1zA= X-Received: by 2002:a7b:c14d:: with SMTP id z13mr1167369wmi.19.1601293301570; Mon, 28 Sep 2020 04:41:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWx1JiSWOM1cKW9D6IoslH4QlbEA/jIiPbXpVDfXEYmi0HuUZmFaDY9rsWdTFKtBI+NKr7OQ== X-Received: by 2002:a7b:c14d:: with SMTP id z13mr1167340wmi.19.1601293301297; Mon, 28 Sep 2020 04:41:41 -0700 (PDT) Received: from [192.168.1.36] (74.red-83-53-161.dynamicip.rima-tde.net. [83.53.161.74]) by smtp.gmail.com with ESMTPSA id 63sm1325145wrc.63.2020.09.28.04.41.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Sep 2020 04:41:40 -0700 (PDT) Subject: Re: [PATCH] vfio-ccw: plug memory leak while getting region info To: Cornelia Huck , Eric Farman References: <20200928101701.13540-1-cohuck@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <29ff3825-d6ad-cd4e-af9d-2f50ca4d9aa2@redhat.com> Date: Mon, 28 Sep 2020 13:41:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200928101701.13540-1-cohuck@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/28 03:47:08 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.687, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Williamson , qemu-s390x@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/28/20 12:17 PM, Cornelia Huck wrote: > vfio_get_dev_region_info() unconditionally allocates memory > for a passed-in vfio_region_info structure (and does not re-use > an already allocated structure). Therefore, we have to free > the structure we pass to that function in vfio_ccw_get_region() > for every region we successfully obtained information for. > > Reported-by: Alex Williamson > Fixes: 8fadea24de4e ("vfio-ccw: support async command subregion") > Fixes: 46ea3841edaf ("vfio-ccw: Add support for the schib region") > Fixes: f030532f2ad6 ("vfio-ccw: Add support for the CRW region and IRQ") > Signed-off-by: Cornelia Huck > --- > hw/vfio/ccw.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé