From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Hao Wu <wuhaotsh@google.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH trivial for 10.1] roms/Makefile: fix npcmNxx_bootrom build rules
Date: Tue, 29 Jul 2025 09:53:48 +0200 [thread overview]
Message-ID: <29fff141-3d78-49bd-8f83-fe16035857a7@linaro.org> (raw)
In-Reply-To: <20250727215511.807880-1-mjt@tls.msk.ru>
On 27/7/25 23:55, Michael Tokarev wrote:
> Since commit 70ce076fa6dff60, the actual rom source dirs
> are subdirs of vbootrom/ submodule, not in top-level of it.
>
> Fixes: 70ce076fa6dff60 "roms: Update vbootrom to 1287b6e"
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> roms/Makefile | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/roms/Makefile b/roms/Makefile
> index beff58d9d5..6af68a922f 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -193,12 +193,12 @@ qboot:
> cp qboot/build/bios.bin ../pc-bios/qboot.rom
>
> npcm7xx_bootrom:
> - $(MAKE) -C vbootrom CROSS_COMPILE=$(arm_cross_prefix)
> - cp vbootrom/npcm7xx_bootrom.bin ../pc-bios/npcm7xx_bootrom.bin
> + $(MAKE) -C vbootrom/npcm7xx CROSS_COMPILE=$(arm_cross_prefix)
> + cp vbootrom/npcm7xx/npcm7xx_bootrom.bin ../pc-bios/npcm7xx_bootrom.bin
>
> npcm8xx_bootrom:
> - $(MAKE) -C vbootrom CROSS_COMPILE=$(aarch64_cross_prefix)
> - cp vbootrom/npcm8xx_bootrom.bin ../pc-bios/npcm8xx_bootrom.bin
> + $(MAKE) -C vbootrom/npcm8xx CROSS_COMPILE=$(aarch64_cross_prefix)
> + cp vbootrom/npcm8xx/npcm8xx_bootrom.bin ../pc-bios/npcm8xx_bootrom.bin
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
(note: not working on macOS, only Linux)
Queued adding:
Fixes: 269b7effd90 ("pc-bios: Add NPCM8XX vBootrom")
Thanks!
prev parent reply other threads:[~2025-07-29 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-27 21:55 [PATCH trivial for 10.1] roms/Makefile: fix npcmNxx_bootrom build rules Michael Tokarev
2025-07-28 8:47 ` Michael Tokarev
2025-07-29 7:53 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29fff141-3d78-49bd-8f83-fe16035857a7@linaro.org \
--to=philmd@linaro.org \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).