* [PATCH] arm/trace: Fix hex printing
@ 2020-10-14 19:33 Dr. David Alan Gilbert (git)
2020-10-14 19:38 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2020-10-14 19:33 UTC (permalink / raw)
To: qemu-devel, eric.auger
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Use of 0x%d - make up our mind as 0x%x
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
hw/arm/trace-events | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
index c8a4d80f6b..a335ee891d 100644
--- a/hw/arm/trace-events
+++ b/hw/arm/trace-events
@@ -41,7 +41,7 @@ smmuv3_get_cd(uint64_t addr) "CD addr: 0x%"PRIx64
smmuv3_decode_cd(uint32_t oas) "oas=%d"
smmuv3_decode_cd_tt(int i, uint32_t tsz, uint64_t ttb, uint32_t granule_sz, bool had) "TT[%d]:tsz:%d ttb:0x%"PRIx64" granule_sz:%d had:%d"
smmuv3_cmdq_cfgi_ste(int streamid) "streamid =%d"
-smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%d - end=0x%d"
+smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%x - end=0x%x"
smmuv3_cmdq_cfgi_cd(uint32_t sid) "streamid = %d"
smmuv3_config_cache_hit(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) "Config cache HIT for sid %d (hits=%d, misses=%d, hit rate=%d)"
smmuv3_config_cache_miss(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) "Config cache MISS for sid %d (hits=%d, misses=%d, hit rate=%d)"
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] arm/trace: Fix hex printing
2020-10-14 19:33 [PATCH] arm/trace: Fix hex printing Dr. David Alan Gilbert (git)
@ 2020-10-14 19:38 ` Philippe Mathieu-Daudé
2020-10-15 7:26 ` Auger Eric
2020-10-19 19:26 ` Peter Maydell
2 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-14 19:38 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), qemu-devel, eric.auger
On 10/14/20 9:33 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Use of 0x%d - make up our mind as 0x%x
Uh...
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
(hw/arm/... in subject)
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/arm/trace-events | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/trace-events b/hw/arm/trace-events
> index c8a4d80f6b..a335ee891d 100644
> --- a/hw/arm/trace-events
> +++ b/hw/arm/trace-events
> @@ -41,7 +41,7 @@ smmuv3_get_cd(uint64_t addr) "CD addr: 0x%"PRIx64
> smmuv3_decode_cd(uint32_t oas) "oas=%d"
> smmuv3_decode_cd_tt(int i, uint32_t tsz, uint64_t ttb, uint32_t granule_sz, bool had) "TT[%d]:tsz:%d ttb:0x%"PRIx64" granule_sz:%d had:%d"
> smmuv3_cmdq_cfgi_ste(int streamid) "streamid =%d"
> -smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%d - end=0x%d"
> +smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%x - end=0x%x"
> smmuv3_cmdq_cfgi_cd(uint32_t sid) "streamid = %d"
> smmuv3_config_cache_hit(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) "Config cache HIT for sid %d (hits=%d, misses=%d, hit rate=%d)"
> smmuv3_config_cache_miss(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) "Config cache MISS for sid %d (hits=%d, misses=%d, hit rate=%d)"
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm/trace: Fix hex printing
2020-10-14 19:33 [PATCH] arm/trace: Fix hex printing Dr. David Alan Gilbert (git)
2020-10-14 19:38 ` Philippe Mathieu-Daudé
@ 2020-10-15 7:26 ` Auger Eric
2020-10-19 19:26 ` Peter Maydell
2 siblings, 0 replies; 7+ messages in thread
From: Auger Eric @ 2020-10-15 7:26 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), qemu-devel
Hi Dave,
On 10/14/20 9:33 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Use of 0x%d - make up our mind as 0x%x
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Acked-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> hw/arm/trace-events | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/trace-events b/hw/arm/trace-events
> index c8a4d80f6b..a335ee891d 100644
> --- a/hw/arm/trace-events
> +++ b/hw/arm/trace-events
> @@ -41,7 +41,7 @@ smmuv3_get_cd(uint64_t addr) "CD addr: 0x%"PRIx64
> smmuv3_decode_cd(uint32_t oas) "oas=%d"
> smmuv3_decode_cd_tt(int i, uint32_t tsz, uint64_t ttb, uint32_t granule_sz, bool had) "TT[%d]:tsz:%d ttb:0x%"PRIx64" granule_sz:%d had:%d"
> smmuv3_cmdq_cfgi_ste(int streamid) "streamid =%d"
> -smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%d - end=0x%d"
> +smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%x - end=0x%x"
> smmuv3_cmdq_cfgi_cd(uint32_t sid) "streamid = %d"
> smmuv3_config_cache_hit(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) "Config cache HIT for sid %d (hits=%d, misses=%d, hit rate=%d)"
> smmuv3_config_cache_miss(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) "Config cache MISS for sid %d (hits=%d, misses=%d, hit rate=%d)"
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm/trace: Fix hex printing
2020-10-14 19:33 [PATCH] arm/trace: Fix hex printing Dr. David Alan Gilbert (git)
2020-10-14 19:38 ` Philippe Mathieu-Daudé
2020-10-15 7:26 ` Auger Eric
@ 2020-10-19 19:26 ` Peter Maydell
2020-10-27 9:24 ` Auger Eric
2 siblings, 1 reply; 7+ messages in thread
From: Peter Maydell @ 2020-10-19 19:26 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: Eric Auger, QEMU Developers
On Wed, 14 Oct 2020 at 20:36, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Use of 0x%d - make up our mind as 0x%x
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/arm/trace-events | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/trace-events b/hw/arm/trace-events
> index c8a4d80f6b..a335ee891d 100644
> --- a/hw/arm/trace-events
> +++ b/hw/arm/trace-events
> @@ -41,7 +41,7 @@ smmuv3_get_cd(uint64_t addr) "CD addr: 0x%"PRIx64
> smmuv3_decode_cd(uint32_t oas) "oas=%d"
> smmuv3_decode_cd_tt(int i, uint32_t tsz, uint64_t ttb, uint32_t granule_sz, bool had) "TT[%d]:tsz:%d ttb:0x%"PRIx64" granule_sz:%d had:%d"
> smmuv3_cmdq_cfgi_ste(int streamid) "streamid =%d"
> -smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%d - end=0x%d"
> +smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%x - end=0x%x"
Ah, I missed that you'd sent this patch before.
Eric, do we want to use hex here, or should we go for
decimal the way we do with (almost) all the other
tracing of stream IDs (eg mmuv3_cmdq_cfgi_ste in the line before)?
The other odd-one-out is smmuv3_find_ste which prints a hex
SID; I think the other tracing of SIDs is always decimal.
thanks
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm/trace: Fix hex printing
2020-10-19 19:26 ` Peter Maydell
@ 2020-10-27 9:24 ` Auger Eric
2020-10-27 10:38 ` Peter Maydell
0 siblings, 1 reply; 7+ messages in thread
From: Auger Eric @ 2020-10-27 9:24 UTC (permalink / raw)
To: Peter Maydell, Dr. David Alan Gilbert (git); +Cc: QEMU Developers
Hi Peter,
On 10/19/20 9:26 PM, Peter Maydell wrote:
> On Wed, 14 Oct 2020 at 20:36, Dr. David Alan Gilbert (git)
> <dgilbert@redhat.com> wrote:
>>
>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>
>> Use of 0x%d - make up our mind as 0x%x
>>
>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> ---
>> hw/arm/trace-events | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/arm/trace-events b/hw/arm/trace-events
>> index c8a4d80f6b..a335ee891d 100644
>> --- a/hw/arm/trace-events
>> +++ b/hw/arm/trace-events
>> @@ -41,7 +41,7 @@ smmuv3_get_cd(uint64_t addr) "CD addr: 0x%"PRIx64
>> smmuv3_decode_cd(uint32_t oas) "oas=%d"
>> smmuv3_decode_cd_tt(int i, uint32_t tsz, uint64_t ttb, uint32_t granule_sz, bool had) "TT[%d]:tsz:%d ttb:0x%"PRIx64" granule_sz:%d had:%d"
>> smmuv3_cmdq_cfgi_ste(int streamid) "streamid =%d"
>> -smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%d - end=0x%d"
>> +smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%x - end=0x%x"
>
> Ah, I missed that you'd sent this patch before.
>
> Eric, do we want to use hex here, or should we go for
> decimal the way we do with (almost) all the other
> tracing of stream IDs (eg mmuv3_cmdq_cfgi_ste in the line before)?
>
> The other odd-one-out is smmuv3_find_ste which prints a hex
> SID; I think the other tracing of SIDs is always decimal.
I think my preference would be to use hexa here and in the other places.
Thanks
Eric
>
> thanks
> -- PMM
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm/trace: Fix hex printing
2020-10-27 9:24 ` Auger Eric
@ 2020-10-27 10:38 ` Peter Maydell
2020-10-27 10:47 ` Auger Eric
0 siblings, 1 reply; 7+ messages in thread
From: Peter Maydell @ 2020-10-27 10:38 UTC (permalink / raw)
To: Auger Eric; +Cc: Dr. David Alan Gilbert (git), QEMU Developers
On Tue, 27 Oct 2020 at 09:24, Auger Eric <eric.auger@redhat.com> wrote:
>
> Hi Peter,
>
> On 10/19/20 9:26 PM, Peter Maydell wrote:
> > Eric, do we want to use hex here, or should we go for
> > decimal the way we do with (almost) all the other
> > tracing of stream IDs (eg mmuv3_cmdq_cfgi_ste in the line before)?
> >
> > The other odd-one-out is smmuv3_find_ste which prints a hex
> > SID; I think the other tracing of SIDs is always decimal.
> I think my preference would be to use hexa here and in the other places.
OK; I'll apply this patch to target-arm.next; feel free to send
a patch updating the other tracepoints to hex.
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-27 10:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-14 19:33 [PATCH] arm/trace: Fix hex printing Dr. David Alan Gilbert (git)
2020-10-14 19:38 ` Philippe Mathieu-Daudé
2020-10-15 7:26 ` Auger Eric
2020-10-19 19:26 ` Peter Maydell
2020-10-27 9:24 ` Auger Eric
2020-10-27 10:38 ` Peter Maydell
2020-10-27 10:47 ` Auger Eric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).