qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH] tests/avocado: add machine:none tag to version.py
Date: Mon, 9 Jan 2023 16:42:42 +0100	[thread overview]
Message-ID: <2a1d1243-2675-8be8-c35f-8c072065645e@linaro.org> (raw)
In-Reply-To: <20221215224725.3236-1-farosas@suse.de>

On 15/12/22 23:47, Fabiano Rosas wrote:
> This test currently fails when run on a host for which the QEMU target
> has no default machine set:
> 
> ERROR| Output: qemu-system-aarch64: No machine specified, and there is
> no default
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   tests/avocado/version.py | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/avocado/version.py b/tests/avocado/version.py
> index ded7f039c1..dd775955eb 100644
> --- a/tests/avocado/version.py
> +++ b/tests/avocado/version.py
> @@ -15,6 +15,7 @@
>   class Version(QemuSystemTest):
>       """
>       :avocado: tags=quick
> +    :avocado: tags=machine:none
>       """
>       def test_qmp_human_info_version(self):
>           self.vm.add_args('-nodefaults')

Looking at previous attempt in 
https://lore.kernel.org/qemu-devel/20220104122104.849084-1-alex.bennee@linaro.org/

* tests/avocado/empty_cpu_model.py

   Forced via vm.add_args('-machine', 'none')

   tags=machine:none would be cleaner.

* tests/avocado/info_usernet.py and
* tests/avocado/vnc.py

   -> Fixed by 5104b73824 ("tests/avocado: set -machine none
   for userfwd and vnc tests")

* tests/avocado/version.py

   -> This patch

* tests/avocado/migration.py

   => Missing

Maybe we can squash to this patch?

Meanwhile:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  parent reply	other threads:[~2023-01-09 15:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15 22:47 [PATCH] tests/avocado: add machine:none tag to version.py Fabiano Rosas
2023-01-09 14:41 ` Fabiano Rosas
2023-01-09 15:42 ` Philippe Mathieu-Daudé [this message]
2023-01-09 16:42   ` Fabiano Rosas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a1d1243-2675-8be8-c35f-8c072065645e@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=farosas@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).