Re: [Qemu-devel] [PATCH v5 08/11] authz: add QAuthZList object type for an access control list

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

Hi Daniel, Markus.

On 09/10/2018 15:04, Daniel P. Berrangé wrote:
...
>  .gitignore              |   4 +
>  MAINTAINERS             |   1 +
>  Makefile                |   7 +-
>  Makefile.objs           |   4 +
>  authz/Makefile.objs     |   1 +
>  authz/list.c            | 315 ++++++++++++++++++++++++++++++++++++++++
>  authz/trace-events      |   4 +
>  include/authz/list.h    | 106 ++++++++++++++
>  qapi/authz.json         |  58 ++++++++
>  qapi/qapi-schema.json   |   1 +
>  tests/Makefile.include  |   4 +
>  tests/test-authz-list.c | 171 ++++++++++++++++++++++
>  12 files changed, 675 insertions(+), 1 deletion(-)
>  create mode 100644 authz/list.c
>  create mode 100644 include/authz/list.h
>  create mode 100644 qapi/authz.json
>  create mode 100644 tests/test-authz-list.c
> 
> diff --git a/.gitignore b/.gitignore
> index 64efdfd929..9b9fcad829 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -47,6 +47,7 @@
>  /qapi/qapi-commands-trace.[ch]
>  /qapi/qapi-commands-transaction.[ch]
>  /qapi/qapi-commands-ui.[ch]
> +/qapi/qapi-commands-authz.[ch]
>  /qapi/qapi-commands.[ch]
>  /qapi/qapi-events-block-core.[ch]
>  /qapi/qapi-events-block.[ch]
> @@ -65,6 +66,7 @@
>  /qapi/qapi-events-trace.[ch]
>  /qapi/qapi-events-transaction.[ch]
>  /qapi/qapi-events-ui.[ch]
> +/qapi/qapi-events-authz.[ch]
>  /qapi/qapi-events.[ch]
>  /qapi/qapi-introspect.[ch]
>  /qapi/qapi-types-block-core.[ch]
> @@ -84,6 +86,7 @@
>  /qapi/qapi-types-trace.[ch]
>  /qapi/qapi-types-transaction.[ch]
>  /qapi/qapi-types-ui.[ch]
> +/qapi/qapi-types-authz.[ch]
>  /qapi/qapi-types.[ch]
>  /qapi/qapi-visit-block-core.[ch]
>  /qapi/qapi-visit-block.[ch]
> @@ -102,6 +105,7 @@
>  /qapi/qapi-visit-trace.[ch]
>  /qapi/qapi-visit-transaction.[ch]
>  /qapi/qapi-visit-ui.[ch]
> +/qapi/qapi-visit-authz.[ch]
>  /qapi/qapi-visit.[ch]
>  /qapi/qapi-doc.texi
>  /qemu-doc.html

We already use the '.inc.c' suffix:

$ git ls-files|fgrep  .inc.c|wc -l
38

What about starting to use the '.gen.c' one with the QAPI generated files?

That would ease the .gitignore maintenance.

Regards,

Phil.