From: Eric Blake <eblake@redhat.com>
To: Elena Afanasova <eafanasova@gmail.com>,
kwolf@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [PATCH] block/blkdebug: fix memory leak
Date: Fri, 9 Oct 2020 14:56:49 -0500 [thread overview]
Message-ID: <2a2b524b-337b-ff2d-d4c9-39e04f4a7a55@redhat.com> (raw)
In-Reply-To: <1e903f928eb3da332cc95e2a6f87243bd9fe66e4.camel@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 898 bytes --]
On 10/9/20 2:09 PM, Elena Afanasova wrote:
> Spotted by PVS-Studio
>
> Signed-off-by: Elena Afanasova <eafanasova@gmail.com>
> ---
> block/blkdebug.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/block/blkdebug.c b/block/blkdebug.c
> index eecbf3e5c4..54da719dd1 100644
> --- a/block/blkdebug.c
> +++ b/block/blkdebug.c
> @@ -215,6 +215,7 @@ static int add_rule(void *opaque, QemuOpts *opts, Error **errp)
> BLKDEBUG_IO_TYPE__MAX, &local_error);
> if (local_error) {
> error_propagate(errp, local_error);
> + g_free(rule);
> return -1;
> }
> if (iotype != BLKDEBUG_IO_TYPE__MAX) {
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-10-09 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 19:09 [PATCH] block/blkdebug: fix memory leak Elena Afanasova
2020-10-09 19:56 ` Eric Blake [this message]
2020-10-12 14:38 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a2b524b-337b-ff2d-d4c9-39e04f4a7a55@redhat.com \
--to=eblake@redhat.com \
--cc=eafanasova@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).