From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency
Date: Thu, 24 Sep 2020 12:30:46 -0700 [thread overview]
Message-ID: <2a2cc60d-2d30-eb38-369e-0a26f0eac9bd@linaro.org> (raw)
In-Reply-To: <fd8a9c3e-45f2-caae-25ab-5e1365fd9298@redhat.com>
On 9/23/20 3:30 AM, Philippe Mathieu-Daudé wrote:
> On 9/23/20 12:16 PM, Peter Maydell wrote:
>> I suppose if we wanted to just use the __builtin_bswap*
>> implementation on all hosts (ie drop the special casing
>> of CONFIG_MACHINE_BSWAP_H/FreeBSD/Haiku) we'd need to
>> rename our macros to avoid potential conflicts with the
>> versions in the system headers there in case they were
>> pulled in via some other path ?
>
> Yes, this is why I couldn't get ride of everything
>
> After reading Paolo's suggestion to use qatomic*, I
> am tempted to suggest qbswap* but I am still looking
> for better alternatives...
Hum, maybe. It's pretty ugly. We could just leave those alone and hope the
system version is decent enough.
r~
next prev parent reply other threads:[~2020-09-24 19:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 10:02 [PATCH 0/4] qemu/bswap: Use compiler __builtin_bswap() Philippe Mathieu-Daudé
2020-09-23 10:02 ` [PATCH 1/4] qemu/bswap: Remove unused qemu_bswap_len() Philippe Mathieu-Daudé
2020-09-24 19:24 ` Richard Henderson
2020-09-23 10:02 ` [PATCH 2/4] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap() Philippe Mathieu-Daudé
2020-09-24 19:25 ` Richard Henderson
2020-09-23 10:02 ` [PATCH 3/4] qemu/bswap: Replace bswapXXs() " Philippe Mathieu-Daudé
2020-09-24 19:29 ` Richard Henderson
2020-09-23 10:02 ` [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency Philippe Mathieu-Daudé
2020-09-23 10:16 ` Peter Maydell
2020-09-23 10:30 ` Philippe Mathieu-Daudé
2020-09-24 19:30 ` Richard Henderson [this message]
2020-09-24 19:33 ` Peter Maydell
2020-09-25 9:22 ` Philippe Mathieu-Daudé
2020-09-25 15:25 ` Richard Henderson
2020-09-24 19:29 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a2cc60d-2d30-eb38-369e-0a26f0eac9bd@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).