From: Laurent Vivier <laurent@vivier.eu>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/4] target/m68k: fix FPSR quotient byte for fmod instruction
Date: Sun, 1 Jan 2023 18:21:17 +0100 [thread overview]
Message-ID: <2a3187a0-883c-db2f-3f18-bc4fb6b158f8@vivier.eu> (raw)
In-Reply-To: <20230101144339.60307-4-mark.cave-ayland@ilande.co.uk>
Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit :
> The FPSR quotient byte should be set to the value of the quotient and not the
> result. Switch from using floatx80_mod() to floatx80_modrem() which returns
> the quotient as a uint64_t which can be used for the quotient byte.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> target/m68k/fpu_helper.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2023-01-01 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-01 14:43 [PATCH 0/4] target/m68k: fix FPSR quotient byte for fmod and frem Mark Cave-Ayland
2023-01-01 14:43 ` [PATCH 1/4] target/m68k: pass quotient directly into make_quotient() Mark Cave-Ayland
2023-01-01 17:20 ` Laurent Vivier
2023-01-01 14:43 ` [PATCH 2/4] target/m68k: pass sign " Mark Cave-Ayland
2023-01-01 17:20 ` Laurent Vivier
2023-01-01 17:26 ` Laurent Vivier
2023-01-01 18:53 ` Richard Henderson
2023-01-02 10:10 ` Mark Cave-Ayland
2023-01-02 17:35 ` Richard Henderson
2023-01-02 10:04 ` Mark Cave-Ayland
2023-01-01 14:43 ` [PATCH 3/4] target/m68k: fix FPSR quotient byte for fmod instruction Mark Cave-Ayland
2023-01-01 17:21 ` Laurent Vivier [this message]
2023-01-01 14:43 ` [PATCH 4/4] target/m68k: fix FPSR quotient byte for frem instruction Mark Cave-Ayland
2023-01-01 17:26 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a3187a0-883c-db2f-3f18-bc4fb6b158f8@vivier.eu \
--to=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).