From: Thomas Huth <thuth@redhat.com>
To: Alistair Francis <alistair23@gmail.com>,
peter.maydell@linaro.org, qemu-devel@nongnu.org,
alex.bennee@linaro.org
Cc: liwei1518@gmail.com, atishp@rivosinc.com, palmer@dabbelt.com,
"Bin Meng" <bmeng.cn@gmail.com>,
zhiwei_liu@linux.alibaba.com,
"Paolo Bonzini" <pbonzini@redhat.com>,
dbarboza@ventanamicro.com, qemu-riscv@nongnu.org,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v2 1/2] hw/char: riscv_htif: Use blocking qemu_chr_fe_write_all
Date: Tue, 3 Sep 2024 07:42:12 +0200 [thread overview]
Message-ID: <2a39f92d-533f-4242-9f21-f9e34a65f4e9@redhat.com> (raw)
In-Reply-To: <20240819113148.3007047-2-alistair.francis@wdc.com>
On 19/08/2024 13.31, Alistair Francis wrote:
> The current approach of using qemu_chr_fe_write() and ignoring the
> return values results in dropped charecters [1]. Ideally we want to
s/charecters/characters/
> report FIFO status to the guest, but the HTIF isn't a real UART, so we
> don't really have a way to do that.
>
> Instead let's just use qemu_chr_fe_write_all() so at least we don't drop
> charecters.
dito
> 1: https://gitlab.com/qemu-project/qemu/-/issues/2114
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
> hw/char/riscv_htif.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
With above typos fixed:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-09-03 5:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 11:31 [PATCH v2 0/2] riscv: char: Avoid dropped charecters Alistair Francis
2024-08-19 11:31 ` [PATCH v2 1/2] hw/char: riscv_htif: Use blocking qemu_chr_fe_write_all Alistair Francis
2024-09-03 5:42 ` Thomas Huth [this message]
2024-08-19 11:31 ` [PATCH v2 2/2] hw/char: sifive_uart: Print uart charecters async Alistair Francis
2024-09-03 5:53 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a39f92d-533f-4242-9f21-f9e34a65f4e9@redhat.com \
--to=thuth@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=alex.bennee@linaro.org \
--cc=alistair23@gmail.com \
--cc=atishp@rivosinc.com \
--cc=bmeng.cn@gmail.com \
--cc=dbarboza@ventanamicro.com \
--cc=liwei1518@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).