From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 449C9C433E2 for ; Thu, 17 Sep 2020 06:55:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF2A32083B for ; Thu, 17 Sep 2020 06:55:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GRuuo+8b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF2A32083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kInoq-0002WJ-O2 for qemu-devel@archiver.kernel.org; Thu, 17 Sep 2020 02:55:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kInnl-0001gB-9f for qemu-devel@nongnu.org; Thu, 17 Sep 2020 02:53:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25693) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kInnj-0006e2-LO for qemu-devel@nongnu.org; Thu, 17 Sep 2020 02:53:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600325630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L0lgBxauyLiUdIl+EnyBv19nWkSNL7xD8jlPKqxDSDs=; b=GRuuo+8bdUKmeDDeW6fSbPXYvXx2QWMeZ8uIW9thlMeHS0Je4rEZuy04DgJNPHKBV1K8RU cgmOv7TaRsjZCVdIU9pQskNWdC5n6i1BzbTgpQ7uubSZ0BSr8GKltFuh6pf3MBAcMRlhwW mkLTT+s4i44s0VSO0Z0xJ+d2yeDiq9U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-O6Jg9PqVOcm526XUh0tDPA-1; Thu, 17 Sep 2020 02:53:46 -0400 X-MC-Unique: O6Jg9PqVOcm526XUh0tDPA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1B91481F01E; Thu, 17 Sep 2020 06:53:42 +0000 (UTC) Received: from thuth.remote.csb (ovpn-113-38.ams2.redhat.com [10.36.113.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9BA9178805; Thu, 17 Sep 2020 06:53:14 +0000 (UTC) Subject: Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros To: Eduardo Habkost , qemu-devel@nongnu.org References: <20200916182519.415636-1-ehabkost@redhat.com> <20200916182519.415636-4-ehabkost@redhat.com> From: Thomas Huth Message-ID: <2a434507-c655-8b2c-30e6-8024b21ab017@redhat.com> Date: Thu, 17 Sep 2020 08:53:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200916182519.415636-4-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/17 02:01:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.062, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Sarah Harris , Chris Wulff , Sagar Karandikar , "Michael S. Tsirkin" , Anthony Green , Mark Cave-Ayland , Jiaxun Yang , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Stefano Stabellini , xen-devel@lists.xenproject.org, Yoshinori Sato , David Hildenbrand , Halil Pasic , Christian Borntraeger , Aleksandar Markovic , "Gonglei \(Arei\)" , Anthony Perard , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Richard Henderson , Artyom Tarasenko , Laurent Vivier , Aleksandar Rikalo , Amit Shah , Alistair Francis , Paul Durrant , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Igor Mammedov , qemu-ppc@nongnu.org, Stafford Horne , Palmer Dabbelt , David Gibson , "Daniel P. Berrange" , qemu-block@nongnu.org, qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Michael Walle , Corey Minyard , Paolo Bonzini , Aurelien Jarno , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16/09/2020 20.25, Eduardo Habkost wrote: > One of the goals of having less boilerplate on QOM declarations > is to avoid human error. Requiring an extra argument that is > never used is an opportunity for mistakes. > > Remove the unused argument from OBJECT_DECLARE_TYPE and > OBJECT_DECLARE_SIMPLE_TYPE. > > Coccinelle patch used to convert all users of the macros: > > @@ > declarer name OBJECT_DECLARE_TYPE; > identifier InstanceType, ClassType, lowercase, UPPERCASE; > @@ > OBJECT_DECLARE_TYPE(InstanceType, ClassType, > - lowercase, > UPPERCASE); > > @@ > declarer name OBJECT_DECLARE_SIMPLE_TYPE; > identifier InstanceType, lowercase, UPPERCASE; > @@ > OBJECT_DECLARE_SIMPLE_TYPE(InstanceType, > - lowercase, > UPPERCASE); > > Signed-off-by: Eduardo Habkost > --- Acked-by: Thomas Huth