qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jordan Justen <jljusten@gmail.com>
To: Alexander Graf <agraf@suse.de>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Implement PC port80 debug register.
Date: Mon, 29 Jun 2009 12:00:09 -0700	[thread overview]
Message-ID: <2a50f7880906291200m53ceea1ctecc1df0ac6010c06@mail.gmail.com> (raw)
In-Reply-To: <59F78767-705A-4A65-BE35-F7B22BB8CA2E@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

Alex,

Well it was write-only before, so I don't see any harm in keeping it that
> way. Or am I mistaken there?
>

As I noted, I have seen it be read/write on real systems.  But, for qemu it
was previously write-only and ignored.

-Jordan

On Mon, Jun 29, 2009 at 11:46 AM, Alexander Graf <agraf@suse.de> wrote:

>
> On 29.06.2009, at 20:39, Anthony Liguori wrote:
>
>  Avi Kivity wrote:
>>
>>> I still think the read/write port route would
>>>> * better emulate systems,
>>>> * be more flexible (allowing software the option to read it),
>>>> * and, be easier to implement :)
>>>>
>>>> But, I think the most important part is to make the data accessible
>>>> somehow.  So, the monitor access method would work fine as well.
>>>>
>>>
>>> I don't object to read/write access.
>>>
>>
>> If there's read and write access, it needs to be part of the savevm state.
>>  Is it per-cpu?  If it's write only, then it doesn't need to be persisted in
>> savevm.
>>
>> I'd lean toward write-only unless there was a compelling reason to make it
>> read/write.
>>
>
> Well it was write-only before, so I don't see any harm in keeping it that
> way. Or am I mistaken there?
>
> Alex
>
>

[-- Attachment #2: Type: text/html, Size: 2108 bytes --]

  parent reply	other threads:[~2009-06-29 19:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-29  8:05 [Qemu-devel] [PATCH] Implement PC port80 debug register Jordan Justen
2009-06-29 13:47 ` Anthony Liguori
2009-06-29 14:17   ` Paul Brook
2009-06-29 14:23   ` Avi Kivity
2009-06-29 14:34     ` Chris Lalancette
2009-06-29 15:26     ` Jordan Justen
2009-06-29 15:31       ` Anthony Liguori
2009-06-29 16:07         ` Jordan Justen
2009-06-29 17:11           ` Avi Kivity
2009-06-29 18:39             ` Anthony Liguori
2009-06-29 18:43               ` Avi Kivity
2009-06-29 18:46               ` Alexander Graf
2009-06-29 18:57                 ` Avi Kivity
2009-06-29 19:00                 ` Jordan Justen [this message]
2009-06-29 19:02               ` Jordan Justen
2009-07-01  7:39               ` Jordan Justen
2009-07-09 18:58                 ` Anthony Liguori
2009-06-29 15:36       ` Avi Kivity
2009-06-29 21:53         ` Jamie Lokier
2009-06-29 23:18         ` Carl-Daniel Hailfinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a50f7880906291200m53ceea1ctecc1df0ac6010c06@mail.gmail.com \
    --to=jljusten@gmail.com \
    --cc=agraf@suse.de \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).