[Qemu-devel] 6a7ad29 regression

[Qemu-devel] 6a7ad29 regression

[Consul]

This commit (6a7ad2998ca47711eddd191caa1a95f14459793f) makes Qemu freeze at startup (before OS is loaded).
Windows XP host and guest, qcow2 image.
Reverting it on top of the most current (42f1ced22) commit makes things run again.

qemu -L . -hda c:\qemu-img\xp2.q2 -boot c -localtime -soundhw es1370 -m 512 -net nic,model=rtl8139 -net tap,ifname=TAP0 -kernel-kqemu


Alex.
-------


Author: Dor Laor <dor@redhat.com>  2009-06-01 02:07:23
Committer: Anthony Liguori <aliguori@us.ibm.com>  2009-06-16 13:36:47
Tags: freezes
Parent: 3fe5c14e7472f88dddf837a9faa60f6abb2ec6bf (Remove dead code)
Child:  8c14c17395809dfb2b20bd3598e067d2c5af7dc4 (kvm: Fix IRQ injection into full queue)
Branches: master, pcap2, remotes/origin/master, test
Follows: bad
Precedes:

     Call qemu_bh_delete at bdrv_aio_bh_cb.

     Also replave qemu_bh_cancel with qemu_bh_delete in bdrv_aio_cancel_em.
      Otherwise the bh will live forever in the bh list.

     Signed-off-by: Dor Laor <dor@redhat.com>
     Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Re: [Qemu-devel] 6a7ad29 regression

[Jordan Justen]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

I found that 6a7ad2998ca47711eddd191caa1a95f14459793f also seems to break
the automatic fat disk generation functionality.  (For example, '-hdb
fat:path/to/make/into/fat/disk')

I reverted 6a7ad29 on top of 52249f0f3c9f101a71ed24e207731525b8431c0a, and
it appeared to fix the issue.

-Jordan


On Wed, Jun 17, 2009 at 5:22 PM, Consul <void@aleksoft.net> wrote:

> This commit (6a7ad2998ca47711eddd191caa1a95f14459793f) makes Qemu freeze at
> startup (before OS is loaded).
> Windows XP host and guest, qcow2 image.
> Reverting it on top of the most current (42f1ced22) commit makes things run
> again.
>
> qemu -L . -hda c:\qemu-img\xp2.q2 -boot c -localtime -soundhw es1370 -m 512
> -net nic,model=rtl8139 -net tap,ifname=TAP0 -kernel-kqemu
>
>
> Alex.
> -------
>
>
> Author: Dor Laor <dor@redhat.com>  2009-06-01 02:07:23
> Committer: Anthony Liguori <aliguori@us.ibm.com>  2009-06-16 13:36:47
> Tags: freezes
> Parent: 3fe5c14e7472f88dddf837a9faa60f6abb2ec6bf (Remove dead code)
> Child:  8c14c17395809dfb2b20bd3598e067d2c5af7dc4 (kvm: Fix IRQ injection
> into full queue)
> Branches: master, pcap2, remotes/origin/master, test
> Follows: bad
> Precedes:
>
>    Call qemu_bh_delete at bdrv_aio_bh_cb.
>
>    Also replave qemu_bh_cancel with qemu_bh_delete in bdrv_aio_cancel_em.
>     Otherwise the bh will live forever in the bh list.
>
>    Signed-off-by: Dor Laor <dor@redhat.com>
>    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 2078 bytes --]

Re: [Qemu-devel] 6a7ad29 regression

[Anthony Liguori]

Jordan Justen wrote:
>
> I found that 6a7ad2998ca47711eddd191caa1a95f14459793f also seems to 
> break the automatic fat disk generation functionality.  (For example, 
> '-hdb fat:path/to/make/into/fat/disk')
>
> I reverted 6a7ad29 on top of 52249f0f3c9f101a71ed24e207731525b8431c0a, 
> and it appeared to fix the issue.

Latest git has a fix that should make the revert unnecessary.  Please test.

Regards,

Anthony Liguori

Re: [Qemu-devel] 6a7ad29 regression

[Jordan Justen]

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

Yes, 0c3271c seems okay.  Thanks Anthony.

On Fri, Jul 10, 2009 at 3:02 PM, Anthony Liguori <anthony@codemonkey.ws>wrote:

> Jordan Justen wrote:
>
>>
>> I found that 6a7ad2998ca47711eddd191caa1a95f14459793f also seems to break
>> the automatic fat disk generation functionality.  (For example, '-hdb
>> fat:path/to/make/into/fat/disk')
>>
>> I reverted 6a7ad29 on top of 52249f0f3c9f101a71ed24e207731525b8431c0a, and
>> it appeared to fix the issue.
>>
>
> Latest git has a fix that should make the revert unnecessary.  Please test.
>
> Regards,
>
> Anthony Liguori
>
>

[-- Attachment #2: Type: text/html, Size: 1060 bytes --]