From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWDNt-0001Ie-IV for qemu-devel@nongnu.org; Wed, 29 Jul 2009 13:56:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWDNq-0001Dn-0P for qemu-devel@nongnu.org; Wed, 29 Jul 2009 13:56:13 -0400 Received: from [199.232.76.173] (port=54632 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWDNp-0001DR-N8 for qemu-devel@nongnu.org; Wed, 29 Jul 2009 13:56:09 -0400 Received: from mail-yx0-f188.google.com ([209.85.210.188]:46287) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWDNp-0000xn-7i for qemu-devel@nongnu.org; Wed, 29 Jul 2009 13:56:09 -0400 Received: by yxe26 with SMTP id 26so1613030yxe.4 for ; Wed, 29 Jul 2009 10:56:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4A7083A7.3050007@codemonkey.ws> References: <1244497683-14391-1-git-send-email-aliguori@us.ibm.com> <1244497683-14391-2-git-send-email-aliguori@us.ibm.com> <4A2D886C.5020007@us.ibm.com> <2a50f7880907290923s4568986cs7548650c9315cdf0@mail.gmail.com> <4A7083A7.3050007@codemonkey.ws> Date: Wed, 29 Jul 2009 10:56:08 -0700 Message-ID: <2a50f7880907291056j27d5bce1iaface600bba5d974@mail.gmail.com> Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA From: Jordan Justen Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org On Wed, Jul 29, 2009 at 10:15 AM, Anthony Liguori wr= ote: > Jordan Justen wrote: >> >> On Mon, Jun 8, 2009 at 2:53 PM, Anthony Liguori >> wrote: >> >>> >>> Anthony Liguori wrote: >>> >>>> >>>> This is needed for VMware VGA to work properly under KVM. >>>> >>>> Signed-off-by: Anthony Liguori >>>> --- >>>> =A0hw/vmware_vga.c | =A0 =A04 ++++ >>>> =A01 files changed, 4 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c >>>> index bb17698..246011b 100644 >>>> --- a/hw/vmware_vga.c >>>> +++ b/hw/vmware_vga.c >>>> @@ -1203,6 +1203,10 @@ static void pci_vmsvga_map_mem(PCIDevice >>>> *pci_dev, >>>> int region_num, >>>> =A0#endif >>>> =A0 =A0cpu_register_physical_memory(s->vram_base, s->vga.vram_size, >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0iomemtype); >>>> + >>>> + =A0 =A0s->vga.map_addr =3D addr; >>>> + =A0 =A0s->vga.map_end =3D addr + s->vga.vram_size; >>>> + =A0 =A0vga_dirty_log_start(&s->vga); >>>> =A0} >>>> >>>> =A0void pci_vmsvga_init(PCIBus *bus) >>>> >>>> >>> >>> N.B. depth is still screwed up with VMware vga but the fix for that loo= ks >>> a >>> bit more non-obvious. =A0This VBE issue has been a long standing proble= m >>> though and I suspect it effects other guests though. >>> >>> >> >> I've tried booting Ubuntu 8.10/9.04 using '-vga vmware' on various >> versions of >> kvm and qemu. =A0The result is always ok video during BIOS post, but gar= bage >> during pre and post X. =A0Would this be a symptom of the 'VBE' issue tha= t >> you mentioned? >> > > Try the latest qemu git. =A0vmware vga should work there. > > I'm not sure about qemu-kvm. =A0It depends on whether the changes survive= d the > merge. > Yes, this is one of the combinations I tried. Latest qemu from git with yo= ur two patches applied. Do you have another distro which you might recommend trying? (Although, I'm not too confident this would be the problem.) > Regards, > > Anthony Liguori >