[PATCH] ARM: Use normal types

[PATCH] ARM: Use normal types

[Juan Quintela]

This is the only use of u_int32_t in the whole tree.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
 bsd-user/arm/target_arch_reg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsd-user/arm/target_arch_reg.h b/bsd-user/arm/target_arch_reg.h
index 070fa24da1..fe9e6584e6 100644
--- a/bsd-user/arm/target_arch_reg.h
+++ b/bsd-user/arm/target_arch_reg.h
@@ -32,7 +32,7 @@ typedef struct target_reg {
 typedef struct target_fp_reg {
     uint32_t        fp_exponent;
     uint32_t        fp_mantissa_hi;
-    u_int32_t       fp_mantissa_lo;
+    uint32_t        fp_mantissa_lo;
 } target_fp_reg_t;
 
 typedef struct target_fpreg {
-- 
2.40.1

Re: [PATCH] ARM: Use normal types

[Philippe Mathieu-Daudé]

On 11/5/23 10:45, Juan Quintela wrote:
> This is the only use of u_int32_t in the whole tree.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   bsd-user/arm/target_arch_reg.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] ARM: Use normal types

[Warner Losh]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

On Thu, May 11, 2023 at 2:45 AM Juan Quintela <quintela@redhat.com> wrote:

> This is the only use of u_int32_t in the whole tree.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>

Reviewed-by: Warner Losh <imp@bsdimp.com>

I'll queue this version if others don't beat me to it. I plan on merging
that around June 1st.

Warner


> ---
>  bsd-user/arm/target_arch_reg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bsd-user/arm/target_arch_reg.h
> b/bsd-user/arm/target_arch_reg.h
> index 070fa24da1..fe9e6584e6 100644
> --- a/bsd-user/arm/target_arch_reg.h
> +++ b/bsd-user/arm/target_arch_reg.h
> @@ -32,7 +32,7 @@ typedef struct target_reg {
>  typedef struct target_fp_reg {
>      uint32_t        fp_exponent;
>      uint32_t        fp_mantissa_hi;
> -    u_int32_t       fp_mantissa_lo;
> +    uint32_t        fp_mantissa_lo;
>  } target_fp_reg_t;
>
>  typedef struct target_fpreg {
> --
> 2.40.1
>
>

[-- Attachment #2: Type: text/html, Size: 1818 bytes --]

[PATCH] ARM: Use normal types

[Juan Quintela]

A bit of history from Warner:

This has been that way the bsd-user sources were reorganized in
2015. I can find no good reason in the FreeBSD sources to do
this (we've been transitioning from the pre-standardized BSD
convention of u_intXX_t -> uintXX_t for 25 years now it seems). I
don't see any old or ancient usage as far back as I looked why they'd
be different. Up through FreeBSD 12.x, this was u_int32_t (for all of
them), but they switched to __uint32_t in FreeBSD 13 to avoid
namespace pollution.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by:  Warner Losh <imp@bsdimp.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>

---

It looks this got lost on previous release
---
 bsd-user/arm/target_arch_reg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsd-user/arm/target_arch_reg.h b/bsd-user/arm/target_arch_reg.h
index 070fa24da1..5f1eea4291 100644
--- a/bsd-user/arm/target_arch_reg.h
+++ b/bsd-user/arm/target_arch_reg.h
@@ -32,7 +32,7 @@ typedef struct target_reg {
 typedef struct target_fp_reg {
     uint32_t        fp_exponent;
     uint32_t        fp_mantissa_hi;
-    u_int32_t       fp_mantissa_lo;
+    uint32_t       fp_mantissa_lo;
 } target_fp_reg_t;
 
 typedef struct target_fpreg {
-- 
2.41.0