* [PATCH] vhost-user-scsi: fix Kconfig dependencies
@ 2021-11-08 9:47 Paolo Bonzini
2021-11-08 9:53 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2021-11-08 9:47 UTC (permalink / raw)
To: qemu-devel; +Cc: felipe
VIRTIO_PCI is a hard dependency for CONFIG_VHOST_USER_SCSI; if virtio-pci
is not included, linking fails due to missing virtio_pci_types_register.
Adjust the Kconfig dependencies.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi/Kconfig b/hw/scsi/Kconfig
index 77d397c949..f972680ffc 100644
--- a/hw/scsi/Kconfig
+++ b/hw/scsi/Kconfig
@@ -50,6 +50,6 @@ config VIRTIO_SCSI
config VHOST_USER_SCSI
bool
+ default y
# Only PCI devices are provided for now
- default y if VIRTIO_PCI
- depends on VIRTIO && VHOST_USER && LINUX
+ depends on VIRTIO_PCI && VHOST_USER && LINUX
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] vhost-user-scsi: fix Kconfig dependencies
2021-11-08 9:47 [PATCH] vhost-user-scsi: fix Kconfig dependencies Paolo Bonzini
@ 2021-11-08 9:53 ` Philippe Mathieu-Daudé
2021-11-08 10:53 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-08 9:53 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: felipe
On 11/8/21 10:47, Paolo Bonzini wrote:
> VIRTIO_PCI is a hard dependency for CONFIG_VHOST_USER_SCSI; if virtio-pci
> is not included, linking fails due to missing virtio_pci_types_register.
> Adjust the Kconfig dependencies.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/scsi/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/Kconfig b/hw/scsi/Kconfig
> index 77d397c949..f972680ffc 100644
> --- a/hw/scsi/Kconfig
> +++ b/hw/scsi/Kconfig
> @@ -50,6 +50,6 @@ config VIRTIO_SCSI
>
> config VHOST_USER_SCSI
> bool
> + default y
> # Only PCI devices are provided for now
> - default y if VIRTIO_PCI
> - depends on VIRTIO && VHOST_USER && LINUX
> + depends on VIRTIO_PCI && VHOST_USER && LINUX
But there is no PCI call there:
$ git grep pci hw/scsi/vhost*scsi*
$
Don't we want to add VHOST_USER_SCSI_PCI in
hw/virtio/Kconfig instead?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost-user-scsi: fix Kconfig dependencies
2021-11-08 9:53 ` Philippe Mathieu-Daudé
@ 2021-11-08 10:53 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-11-08 10:53 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: felipe
On 11/8/21 10:53, Philippe Mathieu-Daudé wrote:
>> config VHOST_USER_SCSI
>> bool
>> + default y
>> # Only PCI devices are provided for now
>> - default y if VIRTIO_PCI
>> - depends on VIRTIO && VHOST_USER && LINUX
>> + depends on VIRTIO_PCI && VHOST_USER && LINUX
> But there is no PCI call there:
Yeah, you're right. You can still access the device on virtio-mmio via
-device vhost-user-scsi.
> $ git grep pci hw/scsi/vhost*scsi*
> $
>
> Don't we want to add VHOST_USER_SCSI_PCI in
> hw/virtio/Kconfig instead?
In practice you already have hw/virtio/vhost-user-scsi.pci conditional
on "CONFIG_VHOST_USER_SCSI && CONFIG_VIRTIO_PCI", and further
configuration is not too useful.
I think the best option is to either make it "default y if VIRTIO_PCI ||
VIRTIO_MMIO", or bite the bullet and add the ccw proxy devices.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-08 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-08 9:47 [PATCH] vhost-user-scsi: fix Kconfig dependencies Paolo Bonzini
2021-11-08 9:53 ` Philippe Mathieu-Daudé
2021-11-08 10:53 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).