From: Damien Zammit <damien@zamaudio.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH qemu] timer/i8254: Fix one shot PIT mode
Date: Sun, 26 Feb 2023 09:17:27 +0000 [thread overview]
Message-ID: <2a62e6fa-3c80-5d07-2b65-0ef27ceabb86@zamaudio.com> (raw)
In-Reply-To: <20230226035018-mutt-send-email-mst@kernel.org>
Hi Michael,
Thanks for reviewing this on a weekend!
On 26/2/23 19:51, Michael S. Tsirkin wrote:
> On Sun, Feb 26, 2023 at 01:58:10AM +0000, Damien Zammit wrote:
>> case 0:
>> - out = (d >= s->count);
>> - break;
>
>
> I think you need something like
> /* FALLTHRU */
> here otherwise some gcc versions will warn.
>
>> case 1:
>> - out = (d < s->count);
>> + out = (d >= s->count);
It seems that there are quite a number of these consecutive fallthrough cases
without /* FALLTHRU */ in i8254_common.c
Can these be fixed in a separate patch?
Damien
next prev parent reply other threads:[~2023-02-26 9:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 1:58 [PATCH qemu] timer/i8254: Fix one shot PIT mode Damien Zammit
2023-02-26 8:51 ` Michael S. Tsirkin
2023-02-26 9:17 ` Damien Zammit [this message]
2023-02-26 9:45 ` Max Filippov
2023-02-26 12:11 ` BALATON Zoltan
2023-02-26 13:03 ` Michael S. Tsirkin
2023-05-15 16:15 ` Michael Tokarev
-- strict thread matches above, loose matches on Subject: below --
2023-10-06 2:36 Damien Zammit
2023-10-06 5:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a62e6fa-3c80-5d07-2b65-0ef27ceabb86@zamaudio.com \
--to=damien@zamaudio.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).