From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chV8U-0001AP-TM for qemu-devel@nongnu.org; Sat, 25 Feb 2017 00:43:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chV8R-0000w4-Sn for qemu-devel@nongnu.org; Sat, 25 Feb 2017 00:43:14 -0500 References: <5077e2a9732e1b9afcb0754e93624b787589ac61.1487522123.git.balaton@eik.bme.hu> From: Thomas Huth Message-ID: <2a70e96a-3f61-473a-519a-af867a050fad@redhat.com> Date: Sat, 25 Feb 2017 06:43:07 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/10] ppc: Add SM501 device in config for ppc and ppcemb targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan , Peter Maydell Cc: QEMU Trivial , QEMU Developers , Aurelien Jarno On 24.02.2017 21:51, BALATON Zoltan wrote: > On Fri, 24 Feb 2017, Peter Maydell wrote: >> On 19 February 2017 at 16:35, BALATON Zoltan wrote: >>> This is not used by default on any emulated machine yet but it is >>> still useful to have it compiled so it can be added from the command >>> line for clients that can use it (e.g. MorphOS has no driver for any >>> other emulated video cards but can output via SM501) >>> >>> Signed-off-by: BALATON Zoltan >> >> If this is a generic PCI device then shouldn't it go into >> default-configs/pci.mak ? > > This is a multimedia chip usually found on sh4 systems and some ppc > boards that's why I've only added it to these but I can move it to > pci.mak if you think it's a better place for it. If it is not really usable for other boards, then I think it should also not go into pci.mak. No need to confuse the users of the other boards with unusable PCI cards here. Thomas