From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Marek Vasut" <marex@denx.de>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Chris Wulff" <crwulff@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH-for-6.2 1/2] disas/nios2: Fix style in print_insn_nios2()
Date: Mon, 9 Aug 2021 08:08:09 +0200 [thread overview]
Message-ID: <2a87e1da-c86b-eaca-e484-cf39e65b9469@redhat.com> (raw)
In-Reply-To: <20210807110939.95853-2-f4bug@amsat.org>
On 07/08/2021 13.09, Philippe Mathieu-Daudé wrote:
> We are going to modify this function, fix its style first.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> disas/nios2.c | 53 +++++++++++++++++++++++++--------------------------
> 1 file changed, 26 insertions(+), 27 deletions(-)
I guess it'd make sense to either re-indent the whole file or to bite the
bullet and life with the checkpatch warnings here ... otherwise you now have
one function that matches the QEMU coding style while the rest of the file
looks completely different.
OTOH, we still can clean that up later, so in case you want to keep this patch:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-08-09 6:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 11:09 [PATCH-for-6.2 0/2] disas/nios2: Simplify endianess conversion Philippe Mathieu-Daudé
2021-08-07 11:09 ` [PATCH-for-6.2 1/2] disas/nios2: Fix style in print_insn_nios2() Philippe Mathieu-Daudé
2021-08-09 6:08 ` Thomas Huth [this message]
2021-08-09 7:14 ` Philippe Mathieu-Daudé
2021-09-29 15:28 ` Laurent Vivier
2021-08-07 11:09 ` [PATCH-for-6.2 2/2] disas/nios2: Simplify endianess conversion Philippe Mathieu-Daudé
2021-08-09 6:12 ` Thomas Huth
2021-08-09 9:48 ` Philippe Mathieu-Daudé
2021-09-29 15:28 ` Laurent Vivier
2021-09-18 9:19 ` [PATCH-for-6.2 0/2] " Philippe Mathieu-Daudé
2021-09-23 15:14 ` Laurent Vivier
2021-09-24 9:40 ` Philippe Mathieu-Daudé
2021-10-19 7:43 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a87e1da-c86b-eaca-e484-cf39e65b9469@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crwulff@gmail.com \
--cc=f4bug@amsat.org \
--cc=marex@denx.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).