Re: [PATCH v6] crypto: Introduce SM4 symmetric cipher algorithm

[Thomas Huth <thuth@redhat.com>]

On 11/03/2024 11.14, Daniel P. Berrangé wrote:
> On Mon, Mar 11, 2024 at 09:32:32AM +0000, Daniel P. Berrangé wrote:
>> On Fri, Mar 08, 2024 at 09:30:52PM +0100, Thomas Huth wrote:
>>> On 07/12/2023 16.47, Hyman Huang wrote:
>>>> Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016).
>>>>
>>>> SM4 (GBT.32907-2016) is a cryptographic standard issued by the
>>>> Organization of State Commercial Administration of China (OSCCA)
>>>> as an authorized cryptographic algorithms for the use within China.
>>>>
>>>> Detect the SM4 cipher algorithms and enable the feature silently
>>>> if it is available.
>>>>
>>>> Signed-off-by: Hyman Huang <yong.huang@smartx.com>
>>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>>> ---
>>>
>>> FYI, starting with this commit, tests/unit/test-crypto-cipher is now failing
>>> on s390x hosts (i.e. big endian machines)... could be that there is maybe an
>>> endianess issue somewhere in here...
>>
>> Or more worringly the issue could be in nettle's impl of SM4, as
>> I'm not seeing an obvious place in this QEMU glue layer which
>> could cause endianness mistakes.
> 
> This is not a s390x problem in fact, it happens on all arches.

Agreed, I can reproduce it on x86 on RHEL as well, so it's indeed a problem 
with the libgcrypt there.

I guess we need a test in "configure" to make sure that SM4 is really available?

  Thomas