From: John Snow <jsnow@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
qemu-trivial@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/ide/ahci: Move allwinner code into a separate file
Date: Thu, 2 Nov 2017 16:56:28 -0400 [thread overview]
Message-ID: <2aa7bf9c-cceb-fdf7-4eac-5d318c854518@redhat.com> (raw)
In-Reply-To: <1508784509-29377-1-git-send-email-thuth@redhat.com>
On 10/23/2017 02:48 PM, Thomas Huth wrote:
> The allwinner code is only needed for the allwinner board (for which
> we also have a separate CONFIG_ALLWINNER_A10 config switch), so it
> does not make sense that we compile this for all the other boards
> that need AHCI, too. Let's move it to a separate file that is only
> compiled when CONFIG_ALLWINNER_A10 is set.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Belated, as it's already merged to master, but:
Thanks, applied to my IDE tree:
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js
prev parent reply other threads:[~2017-11-02 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 18:48 [Qemu-devel] [PATCH] hw/ide/ahci: Move allwinner code into a separate file Thomas Huth
2017-10-23 21:44 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-11-02 20:56 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2aa7bf9c-cceb-fdf7-4eac-5d318c854518@redhat.com \
--to=jsnow@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).