From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH for-3.1?] target/arm/sve_helper: Fix compilation with clang 3.4
Date: Wed, 28 Nov 2018 15:34:21 +0100 [thread overview]
Message-ID: <2ac07515-10f3-ed38-c022-e583cd1cd36a@redhat.com> (raw)
In-Reply-To: <1543399094-2260-1-git-send-email-thuth@redhat.com>
On 28/11/18 10:58, Thomas Huth wrote:
> Clang 3.4 does not know the "flatten" attribute yet. We've already
> introduced the QEMU_FLATTEN macro for this in commit 97ff87c0ed020c2,
> so use this macro now here, too, to fix this issue.
checkpatch candidate?
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> target/arm/sve_helper.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c
> index 8cbc651..bc84725 100644
> --- a/target/arm/sve_helper.c
> +++ b/target/arm/sve_helper.c
> @@ -4382,20 +4382,20 @@ static void sve_ld4_r(CPUARMState *env, void *vg, target_ulong addr,
> }
>
> #define DO_LDN_1(N) \
> -void __attribute__((flatten)) HELPER(sve_ld##N##bb_r) \
> +void QEMU_FLATTEN HELPER(sve_ld##N##bb_r) \
> (CPUARMState *env, void *vg, target_ulong addr, uint32_t desc) \
> { \
> sve_ld##N##_r(env, vg, addr, desc, 1, GETPC(), sve_ld1bb_tlb); \
> }
>
> #define DO_LDN_2(N, SUFF, SIZE) \
> -void __attribute__((flatten)) HELPER(sve_ld##N##SUFF##_le_r) \
> +void QEMU_FLATTEN HELPER(sve_ld##N##SUFF##_le_r) \
> (CPUARMState *env, void *vg, target_ulong addr, uint32_t desc) \
> { \
> sve_ld##N##_r(env, vg, addr, desc, SIZE, GETPC(), \
> sve_ld1##SUFF##_le_tlb); \
> } \
> -void __attribute__((flatten)) HELPER(sve_ld##N##SUFF##_be_r) \
> +void QEMU_FLATTEN HELPER(sve_ld##N##SUFF##_be_r) \
> (CPUARMState *env, void *vg, target_ulong addr, uint32_t desc) \
> { \
> sve_ld##N##_r(env, vg, addr, desc, SIZE, GETPC(), \
> @@ -4832,7 +4832,7 @@ static void sve_st4_r(CPUARMState *env, void *vg, target_ulong addr,
> }
>
> #define DO_STN_1(N, NAME, ESIZE) \
> -void __attribute__((flatten)) HELPER(sve_st##N##NAME##_r) \
> +void QEMU_FLATTEN HELPER(sve_st##N##NAME##_r) \
> (CPUARMState *env, void *vg, target_ulong addr, uint32_t desc) \
> { \
> sve_st##N##_r(env, vg, addr, desc, GETPC(), ESIZE, 1, \
> @@ -4840,13 +4840,13 @@ void __attribute__((flatten)) HELPER(sve_st##N##NAME##_r) \
> }
>
> #define DO_STN_2(N, NAME, ESIZE, MSIZE) \
> -void __attribute__((flatten)) HELPER(sve_st##N##NAME##_le_r) \
> +void QEMU_FLATTEN HELPER(sve_st##N##NAME##_le_r) \
> (CPUARMState *env, void *vg, target_ulong addr, uint32_t desc) \
> { \
> sve_st##N##_r(env, vg, addr, desc, GETPC(), ESIZE, MSIZE, \
> sve_st1##NAME##_le_tlb); \
> } \
> -void __attribute__((flatten)) HELPER(sve_st##N##NAME##_be_r) \
> +void QEMU_FLATTEN HELPER(sve_st##N##NAME##_be_r) \
> (CPUARMState *env, void *vg, target_ulong addr, uint32_t desc) \
> { \
> sve_st##N##_r(env, vg, addr, desc, GETPC(), ESIZE, MSIZE, \
> @@ -4966,7 +4966,7 @@ static void sve_ld1_zd(CPUARMState *env, void *vd, void *vg, void *vm,
> }
>
> #define DO_LD1_ZPZ_S(MEM, OFS) \
> -void __attribute__((flatten)) HELPER(sve_ld##MEM##_##OFS) \
> +void QEMU_FLATTEN HELPER(sve_ld##MEM##_##OFS) \
> (CPUARMState *env, void *vd, void *vg, void *vm, \
> target_ulong base, uint32_t desc) \
> { \
> @@ -4975,7 +4975,7 @@ void __attribute__((flatten)) HELPER(sve_ld##MEM##_##OFS) \
> }
>
> #define DO_LD1_ZPZ_D(MEM, OFS) \
> -void __attribute__((flatten)) HELPER(sve_ld##MEM##_##OFS) \
> +void QEMU_FLATTEN HELPER(sve_ld##MEM##_##OFS) \
> (CPUARMState *env, void *vd, void *vg, void *vm, \
> target_ulong base, uint32_t desc) \
> { \
> @@ -5326,7 +5326,7 @@ static void sve_st1_zd(CPUARMState *env, void *vd, void *vg, void *vm,
> }
>
> #define DO_ST1_ZPZ_S(MEM, OFS) \
> -void __attribute__((flatten)) HELPER(sve_st##MEM##_##OFS) \
> +void QEMU_FLATTEN HELPER(sve_st##MEM##_##OFS) \
> (CPUARMState *env, void *vd, void *vg, void *vm, \
> target_ulong base, uint32_t desc) \
> { \
> @@ -5335,7 +5335,7 @@ void __attribute__((flatten)) HELPER(sve_st##MEM##_##OFS) \
> }
>
> #define DO_ST1_ZPZ_D(MEM, OFS) \
> -void __attribute__((flatten)) HELPER(sve_st##MEM##_##OFS) \
> +void QEMU_FLATTEN HELPER(sve_st##MEM##_##OFS) \
> (CPUARMState *env, void *vd, void *vg, void *vm, \
> target_ulong base, uint32_t desc) \
> { \
>
next prev parent reply other threads:[~2018-11-28 14:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 9:58 [Qemu-devel] [PATCH for-3.1?] target/arm/sve_helper: Fix compilation with clang 3.4 Thomas Huth
2018-11-28 14:09 ` Richard Henderson
2018-11-28 14:34 ` Philippe Mathieu-Daudé [this message]
2018-11-28 14:39 ` Thomas Huth
2018-11-28 15:50 ` Philippe Mathieu-Daudé
2018-11-28 15:54 ` Peter Maydell
2018-11-28 15:32 ` Peter Maydell
2018-11-28 16:05 ` Daniel P. Berrangé
2018-11-28 16:50 ` Thomas Huth
2018-11-28 16:58 ` Daniel P. Berrangé
2018-11-28 19:09 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac07515-10f3-ed38-c022-e583cd1cd36a@redhat.com \
--to=philmd@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).