From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5448DC4332F for ; Thu, 9 Nov 2023 23:00:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1E0v-0007AT-3C; Thu, 09 Nov 2023 18:00:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1E0r-00078m-09; Thu, 09 Nov 2023 18:00:37 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1E0p-0003If-Cm; Thu, 09 Nov 2023 18:00:36 -0500 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A9Mu05q019329; Thu, 9 Nov 2023 23:00:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=2m6Il01lHSiDS/SNNoHL07Wv2SoghJZcuFWzMQa6k/g=; b=ey4bWRpe4uPEvIv764jKLmuMGDY0GTPt54L8dtry/13NPKu0HVBu6xYAi3s0iyeqYZLK yySOBgTwBih2a8Bl80gm1bPTCa8CkbcKW5ngtS1iwuogVGuuBBwler3kI2Qn6fd/5WCl rQ2AbrI1Ub7+NUjA0uGh+ZuBt8DuYJwOVjwwuq0MS1gMOitMvgW+GW+68EHtE7D53Kk+ f8d5BXbImDuWaRCpKGNBKDaE70lhj9Hi/oKHUE/jaWiK6NRGRPSXXLAOnUjunqCtH/Pm na9NKk83kdXqoXkIzwHcSGhkb+nMGnka3bABWs2E9rYAhppt7ixrA3IE/mm8+bOCUQFg RQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u98n502qr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Nov 2023 23:00:32 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3A9Mxjmm029112; Thu, 9 Nov 2023 23:00:31 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u98n502pw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Nov 2023 23:00:31 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3A9M1XuQ019248; Thu, 9 Nov 2023 23:00:30 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3u7w2470dy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Nov 2023 23:00:30 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3A9N0TLg23200380 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Nov 2023 23:00:30 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DD4C758080; Thu, 9 Nov 2023 23:00:29 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5AB295807B; Thu, 9 Nov 2023 23:00:28 +0000 (GMT) Received: from [9.61.66.47] (unknown [9.61.66.47]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 9 Nov 2023 23:00:28 +0000 (GMT) Message-ID: <2acb76b0-00cd-a448-f615-0cb1825e81a0@linux.ibm.com> Date: Thu, 9 Nov 2023 18:00:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 19/20] kconfig: Activate IOMMUFD for s390x machines Content-Language: en-US To: Zhenzhong Duan , qemu-devel@nongnu.org Cc: alex.williamson@redhat.com, clg@redhat.com, jgg@nvidia.com, nicolinc@nvidia.com, joao.m.martins@oracle.com, eric.auger@redhat.com, peterx@redhat.com, jasowang@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, yi.y.sun@intel.com, chao.p.peng@intel.com, Paolo Bonzini , Richard Henderson , David Hildenbrand , Ilya Leoshkevich , Halil Pasic , Christian Borntraeger , Eric Farman , Thomas Huth , "open list:S390 TCG CPUs" References: <20231109114529.1904193-1-zhenzhong.duan@intel.com> <20231109114529.1904193-20-zhenzhong.duan@intel.com> From: Matthew Rosato In-Reply-To: <20231109114529.1904193-20-zhenzhong.duan@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: BlDdRdVNVAWOsfxLIdb_OexbVJzHyxQ3 X-Proofpoint-ORIG-GUID: BSsdBB7gKY0-VMSIh7PM-8YJJaOM1cEp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-09_16,2023-11-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 lowpriorityscore=0 phishscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311090168 Received-SPF: pass client-ip=148.163.158.5; envelope-from=mjrosato@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -52 X-Spam_score: -5.3 X-Spam_bar: ----- X-Spam_report: (-5.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.265, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/9/23 6:45 AM, Zhenzhong Duan wrote: > From: Cédric Le Goater > > Signed-off-by: Cédric Le Goater > Signed-off-by: Zhenzhong Duan > --- > hw/s390x/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/s390x/Kconfig b/hw/s390x/Kconfig > index 4c068d7960..26ad104485 100644 > --- a/hw/s390x/Kconfig > +++ b/hw/s390x/Kconfig > @@ -6,6 +6,7 @@ config S390_CCW_VIRTIO > imply VFIO_CCW > imply WDT_DIAG288 > imply PCIE_DEVICES > + imply IOMMUFD > select PCI_EXPRESS > select S390_FLIC > select S390_FLIC_KVM if KVM Reviewed-by: Matthew Rosato I also ran tests against vfio-pci (mlx, ism, nvme), vfio-ap and vfio-ccw on s390x with an iommufd-enabled host kernel + this series. Testing included having qemu open both fds, passing in one fd and letting qemu open the other, and passing in both fds.