qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: Joel Stanley <joel@jms.id.au>, Ninad Palsule <ninad@linux.ibm.com>
Cc: qemu-devel@nongnu.org, andrew@aj.id.au, clg@kaod.org
Subject: Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus
Date: Mon, 27 Mar 2023 08:31:55 -0400	[thread overview]
Message-ID: <2acc460f-95de-fa22-a9b1-f02e198147b0@linux.ibm.com> (raw)
In-Reply-To: <2ef78250-dfe6-688f-eb27-9af97ce593e7@linux.ibm.com>



On 3/27/23 07:11, Stefan Berger wrote:
> 
> 

>> We get this message when booting from a kernel:
>>
>> [    0.582699] tpm_tis_i2c 12-002e: 2.0 TPM (device-id 0x1, rev-id 1)
>> [    0.586361] tpm tpm0: A TPM error (256) occurred attempting the self test
>> [    0.586623] tpm tpm0: starting up the TPM manually
>>
>> Do we understand why the error appears?
> 
> The firmware did not initialize the TPM 2.
> 

>> However on a clean boot into the TPM, the u-boot tpm commands fail:
>>
>> ast# tpm info
>> tpm@2e v2.0: VendorID 0x1014, DeviceID 0x0001, RevisionID 0x01 [closed]
>> ast# tpINTERRUPT>
> 
> Is this normal output? Is it an indication of some sort of IRQ?
> 
>> ast# tpm init
>> ast# tpm info
>> tpm@2e v2.0: VendorID 0x1014, DeviceID 0x0001, RevisionID 0x01 [open]
>> ast# tpm pcr_read 0 0x81000000
>> Error: 256

If this is an error from the TPM 2 , then the 256 error code is the same as reported by Linux above:

$ tssreturncode 0x100
TPM_RC_INITIALIZE - TPM not initialized by TPM2_Startup or already initialized


I will try to reproduce this today. u-boot should have a sent TPM2_Startup as part of 'tpm init' command above or even before on its own.

     Stefan


  parent reply	other threads:[~2023-03-27 12:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-26 22:44 [PATCH v7 0/3] Add support for TPM devices over I2C bus Ninad Palsule
2023-03-26 22:44 ` [PATCH v7 1/3] docs: " Ninad Palsule
2023-03-27  7:47   ` Joel Stanley
2023-03-27  7:52     ` Cédric Le Goater
2023-03-27 14:48       ` Ninad Palsule
2023-03-27 15:10         ` Cédric Le Goater
2023-03-27 15:28           ` Ninad Palsule
2023-03-27 13:04     ` Ninad Palsule
2023-03-26 22:44 ` [PATCH v7 2/3] tpm: Extend common APIs to support TPM TIS I2C Ninad Palsule
2023-03-27  0:14   ` Stefan Berger
2023-03-26 22:44 ` [PATCH v7 3/3] tpm: Add support for TPM device over I2C bus Ninad Palsule
2023-03-27 13:40   ` Stefan Berger
2023-03-27 15:54     ` Ninad Palsule
2023-03-27  1:05 ` [PATCH v7 0/3] Add support for TPM devices " Joel Stanley
2023-03-27  3:52   ` Ninad Palsule
2023-03-27  8:04     ` Joel Stanley
2023-03-27  8:20       ` Cédric Le Goater
2023-03-27 10:49         ` Joel Stanley
2023-03-27 11:17       ` Stefan Berger
2023-03-27 11:11   ` Stefan Berger
2023-03-27 11:18     ` Joel Stanley
2023-03-27 11:24       ` Stefan Berger
2023-03-27 12:31     ` Stefan Berger [this message]
2023-03-27 13:09       ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2acc460f-95de-fa22-a9b1-f02e198147b0@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=andrew@aj.id.au \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=ninad@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).