From: Max Reitz <mreitz@redhat.com>
To: John Snow <jsnow@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/3] iotests: use python logging for iotests.log()
Date: Mon, 9 Sep 2019 12:18:29 +0200 [thread overview]
Message-ID: <2af4c984-3290-d928-1a6b-4705f2aa70bc@redhat.com> (raw)
In-Reply-To: <20190729213559.20913-4-jsnow@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 675 bytes --]
On 29.07.19 23:35, John Snow wrote:
> We can turn logging on/off globally instead of per-function.
>
> Remove use_log from run_job, and use python logging to turn on
> diffable output when we run through a script entry point.
>
> iotest 245 changes output order due to buffering reasons.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/qemu-iotests/030 | 4 +--
> tests/qemu-iotests/245 | 1 +
> tests/qemu-iotests/245.out | 24 +++++++++---------
> tests/qemu-iotests/iotests.py | 47 +++++++++++++++++++++--------------
> 4 files changed, 43 insertions(+), 33 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-09-09 10:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 21:35 [Qemu-devel] [PATCH v2 0/3] iotests: use python logging John Snow
2019-07-29 21:35 ` [Qemu-devel] [PATCH v2 1/3] iotests: add script_initialize John Snow
2019-09-09 10:06 ` Max Reitz
2019-09-09 18:25 ` John Snow
2019-09-10 8:41 ` Max Reitz
2019-07-29 21:35 ` [Qemu-devel] [PATCH v2 2/3] iotests: add protocol support to initialization info John Snow
2019-09-09 10:09 ` Max Reitz
2019-09-09 18:45 ` John Snow
2019-09-10 8:43 ` Max Reitz
2019-07-29 21:35 ` [Qemu-devel] [PATCH v2 3/3] iotests: use python logging for iotests.log() John Snow
2019-09-09 10:18 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2af4c984-3290-d928-1a6b-4705f2aa70bc@redhat.com \
--to=mreitz@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).