From: Richard Henderson <richard.henderson@linaro.org>
To: "Matheus K. Ferst" <matheus.ferst@eldorado.org.br>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: thuth@redhat.com, danielhb413@gmail.com, groug@kaod.org,
philippe.mathieu.daude@gmail.com, clg@kaod.org,
mrezanin@redhat.com, alex.bennee@linaro.org,
david@gibson.dropbear.id.au
Subject: Re: [PATCH v2 5/5] tests/tcg/ppc64le: Use Altivec register names in clobbler list
Date: Thu, 3 Mar 2022 11:05:27 -1000 [thread overview]
Message-ID: <2b027e56-dc17-73ed-99e7-a04b38f2a4a5@linaro.org> (raw)
In-Reply-To: <5fa9dcf4-fcd6-ddb6-ad87-a5a15d283ebb@eldorado.org.br>
On 3/3/22 10:53, Matheus K. Ferst wrote:
> On 03/03/2022 16:30, Richard Henderson wrote:
>> On 3/3/22 07:20, matheus.ferst@eldorado.org.br wrote:
>>> From: Matheus Ferst <matheus.ferst@eldorado.org.br>
>>>
>>> LLVM/Clang doesn't know the VSX registers when compiling with
>>> -mabi=elfv1. Use only registers >= 32 and list them with their Altivec
>>> name.
>>>
>>> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
>>
>> This description isn't quite right. The change to the m[tf]vsr insns is a generic bug
>> fix, and not related to Clang.
>>
>
> I'm not sure if I understood. I'm targeting the Clang problem with this patch, is
> something else being fixed by this change?
> AFAICT, the old "mtvsrd 0, %2" and "mfvsrd %0, 0" were correct, I'm just changing from VSR
> 0 to VSR 32 to allow the clobber with Clang, but GCC doesn't seem to have this limitation
> with ELFv1.
Oh, whoops, I mis-read the patch.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2022-03-03 21:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 17:20 [PATCH v2 0/5] tests/tcg/ppc64le: fix the build of TCG tests with Clang matheus.ferst
2022-03-03 17:20 ` [PATCH v2 1/5] tests/tcg/ppc64le: use inline asm instead of __builtin_mtfsf matheus.ferst
2022-03-03 18:46 ` Richard Henderson
2022-03-03 17:20 ` [PATCH v2 2/5] target/ppc: change xs[n]madd[am]sp to use float64r32_muladd matheus.ferst
2022-03-03 18:49 ` Richard Henderson
2022-03-03 20:53 ` Matheus K. Ferst
2022-03-03 17:20 ` [RFC PATCH v2 3/5] tests/tcg/ppc64le: drop __int128 usage in bcdsub matheus.ferst
2022-03-03 18:57 ` Richard Henderson
2022-03-03 17:20 ` [RFC PATCH v2 4/5] tests/tcg/ppc64le: emit bcdsub with .long when needed matheus.ferst
2022-03-03 19:19 ` Richard Henderson
2022-03-03 17:20 ` [PATCH v2 5/5] tests/tcg/ppc64le: Use Altivec register names in clobbler list matheus.ferst
2022-03-03 19:30 ` Richard Henderson
2022-03-03 20:53 ` Matheus K. Ferst
2022-03-03 21:05 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b027e56-dc17-73ed-99e7-a04b38f2a4a5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=matheus.ferst@eldorado.org.br \
--cc=mrezanin@redhat.com \
--cc=philippe.mathieu.daude@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).