From: Richard Henderson <rth@twiddle.net>
To: peer.adelt@c-lab.de, qemu-devel@nongnu.org
Cc: kbastian@mail.uni-paderborn.de
Subject: Re: [Qemu-devel] [PATCH 3/4] target-tricore: Added new MOV instruction variant
Date: Sat, 4 Jun 2016 10:04:55 -0700 [thread overview]
Message-ID: <2b10121c-e540-d72f-98f8-ad9b2f98e200@twiddle.net> (raw)
In-Reply-To: <1464562768-8954-4-git-send-email-peer.adelt@c-lab.de>
On 05/29/2016 03:59 PM, peer.adelt@c-lab.de wrote:
> + tcg_gen_mov_tl(cpu_gpr_d[r3], cpu_gpr_d[r1]);
> + tcg_gen_mov_tl(cpu_gpr_d[(r3 + 1)], cpu_gpr_d[r2]);
Don't add pointless parenthesis.
But more importantly, you need to worry about overlap between r3 and r2.
In the general case you'll need a temporary to perform this move.
r~
next prev parent reply other threads:[~2016-06-04 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 22:59 [Qemu-devel] [PATCH 0/4] Added 5 instructions to the tricore target peer.adelt
2016-05-29 22:59 ` [Qemu-devel] [PATCH 1/4] target-tricore: Added FTOUZ instruction peer.adelt
2016-05-30 7:09 ` Bastian Koppelmann
2016-06-04 16:46 ` Richard Henderson
2016-05-29 22:59 ` [Qemu-devel] [PATCH 2/4] target-tricore: Added MADD.F and MSUB.F instructions peer.adelt
2016-05-31 11:13 ` Bastian Koppelmann
2016-06-04 16:55 ` Richard Henderson
2016-05-29 22:59 ` [Qemu-devel] [PATCH 3/4] target-tricore: Added new MOV instruction variant peer.adelt
2016-05-30 7:13 ` Bastian Koppelmann
2016-06-04 17:04 ` Richard Henderson [this message]
2016-05-29 22:59 ` [Qemu-devel] [PATCH 4/4] target-tricore: Added new JNE " peer.adelt
2016-05-30 8:17 ` Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b10121c-e540-d72f-98f8-ad9b2f98e200@twiddle.net \
--to=rth@twiddle.net \
--cc=kbastian@mail.uni-paderborn.de \
--cc=peer.adelt@c-lab.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).