From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41965)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1b9F0R-0003Pn-43
	for qemu-devel@nongnu.org; Sat, 04 Jun 2016 13:05:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1b9F0M-0002xj-St
	for qemu-devel@nongnu.org; Sat, 04 Jun 2016 13:05:02 -0400
Received: from mail-pf0-x231.google.com ([2607:f8b0:400e:c00::231]:34739)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1b9F0M-0002xf-L8
	for qemu-devel@nongnu.org; Sat, 04 Jun 2016 13:04:58 -0400
Received: by mail-pf0-x231.google.com with SMTP id 62so53657739pfd.1
	for <qemu-devel@nongnu.org>; Sat, 04 Jun 2016 10:04:58 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1464562768-8954-1-git-send-email-peer.adelt@c-lab.de>
	<1464562768-8954-4-git-send-email-peer.adelt@c-lab.de>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <2b10121c-e540-d72f-98f8-ad9b2f98e200@twiddle.net>
Date: Sat, 4 Jun 2016 10:04:55 -0700
MIME-Version: 1.0
In-Reply-To: <1464562768-8954-4-git-send-email-peer.adelt@c-lab.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] target-tricore: Added new MOV
 instruction variant
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: peer.adelt@c-lab.de, qemu-devel@nongnu.org
Cc: kbastian@mail.uni-paderborn.de

On 05/29/2016 03:59 PM, peer.adelt@c-lab.de wrote:
> +        tcg_gen_mov_tl(cpu_gpr_d[r3], cpu_gpr_d[r1]);
> +        tcg_gen_mov_tl(cpu_gpr_d[(r3 + 1)], cpu_gpr_d[r2]);

Don't add pointless parenthesis.

But more importantly, you need to worry about overlap between r3 and r2.
In the general case you'll need a temporary to perform this move.


r~