* [PATCH v2] configure: Do not intent to build WHPX on 32-bit host
@ 2020-09-10 5:45 Philippe Mathieu-Daudé
2020-09-10 5:48 ` Stefan Weil
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-10 5:45 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Thomas Huth, Philippe Mathieu-Daudé,
Sunil Muthuswamy, Stefan Weil
Hyper-V is available on 64-bit versions of Windows,
do not try to build its support on 32-bit versions.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Since v1: Handle MinGW automatic detection (Thomas, Stefan)
---
configure | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 4231d56bcc0..91c5d781845 100755
--- a/configure
+++ b/configure
@@ -2980,7 +2980,10 @@ fi
##########################################
# Windows Hypervisor Platform accelerator (WHPX) check
-if test "$whpx" != "no" ; then
+if test "$whpx" = "yes" && test "$ARCH" != "x86_64"; then
+ error_exit "WHPX requires 64-bit host"
+fi
+if test "$whpx" != "no" && test "$ARCH" = "x86_64"; then
if check_include "WinHvPlatform.h" && check_include "WinHvEmulation.h"; then
whpx="yes"
else
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] configure: Do not intent to build WHPX on 32-bit host
2020-09-10 5:45 [PATCH v2] configure: Do not intent to build WHPX on 32-bit host Philippe Mathieu-Daudé
@ 2020-09-10 5:48 ` Stefan Weil
2020-09-11 17:14 ` Paolo Bonzini
2020-09-11 17:18 ` Eric Blake
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Weil @ 2020-09-10 5:48 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Paolo Bonzini, Thomas Huth, Sunil Muthuswamy
Am 10.09.20 um 07:45 schrieb Philippe Mathieu-Daudé:
> Hyper-V is available on 64-bit versions of Windows,
> do not try to build its support on 32-bit versions.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Since v1: Handle MinGW automatic detection (Thomas, Stefan)
> ---
> configure | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4231d56bcc0..91c5d781845 100755
> --- a/configure
> +++ b/configure
> @@ -2980,7 +2980,10 @@ fi
>
> ##########################################
> # Windows Hypervisor Platform accelerator (WHPX) check
> -if test "$whpx" != "no" ; then
> +if test "$whpx" = "yes" && test "$ARCH" != "x86_64"; then
> + error_exit "WHPX requires 64-bit host"
> +fi
> +if test "$whpx" != "no" && test "$ARCH" = "x86_64"; then
> if check_include "WinHvPlatform.h" && check_include "WinHvEmulation.h"; then
> whpx="yes"
> else
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] configure: Do not intent to build WHPX on 32-bit host
2020-09-10 5:45 [PATCH v2] configure: Do not intent to build WHPX on 32-bit host Philippe Mathieu-Daudé
2020-09-10 5:48 ` Stefan Weil
@ 2020-09-11 17:14 ` Paolo Bonzini
2020-09-11 17:18 ` Eric Blake
2 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2020-09-11 17:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Stefan Weil, Thomas Huth, Sunil Muthuswamy
On 10/09/20 07:45, Philippe Mathieu-Daudé wrote:
> Hyper-V is available on 64-bit versions of Windows,
> do not try to build its support on 32-bit versions.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Since v1: Handle MinGW automatic detection (Thomas, Stefan)
> ---
> configure | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4231d56bcc0..91c5d781845 100755
> --- a/configure
> +++ b/configure
> @@ -2980,7 +2980,10 @@ fi
>
> ##########################################
> # Windows Hypervisor Platform accelerator (WHPX) check
> -if test "$whpx" != "no" ; then
> +if test "$whpx" = "yes" && test "$ARCH" != "x86_64"; then
> + error_exit "WHPX requires 64-bit host"
> +fi
> +if test "$whpx" != "no" && test "$ARCH" = "x86_64"; then
> if check_include "WinHvPlatform.h" && check_include "WinHvEmulation.h"; then
> whpx="yes"
> else
>
Queued this one instead.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] configure: Do not intent to build WHPX on 32-bit host
2020-09-10 5:45 [PATCH v2] configure: Do not intent to build WHPX on 32-bit host Philippe Mathieu-Daudé
2020-09-10 5:48 ` Stefan Weil
2020-09-11 17:14 ` Paolo Bonzini
@ 2020-09-11 17:18 ` Eric Blake
2020-09-11 17:24 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 5+ messages in thread
From: Eric Blake @ 2020-09-11 17:18 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Paolo Bonzini, Thomas Huth, Sunil Muthuswamy, Stefan Weil
On 9/10/20 12:45 AM, Philippe Mathieu-Daudé wrote:
In the subject, s/intent/attempt/
> Hyper-V is available on 64-bit versions of Windows,
> do not try to build its support on 32-bit versions.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Since v1: Handle MinGW automatic detection (Thomas, Stefan)
> ---
> configure | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> --
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] configure: Do not intent to build WHPX on 32-bit host
2020-09-11 17:18 ` Eric Blake
@ 2020-09-11 17:24 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-11 17:24 UTC (permalink / raw)
To: Eric Blake, qemu-devel
Cc: Paolo Bonzini, Thomas Huth, Sunil Muthuswamy, Stefan Weil
On 9/11/20 7:18 PM, Eric Blake wrote:
> On 9/10/20 12:45 AM, Philippe Mathieu-Daudé wrote:
>
> In the subject, s/intent/attempt/
Oops thanks... Paolo can you fix that directly,
or should I repost?
>
>> Hyper-V is available on 64-bit versions of Windows,
>> do not try to build its support on 32-bit versions.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> Since v1: Handle MinGW automatic detection (Thomas, Stefan)
>> ---
>> configure | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-11 17:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-10 5:45 [PATCH v2] configure: Do not intent to build WHPX on 32-bit host Philippe Mathieu-Daudé
2020-09-10 5:48 ` Stefan Weil
2020-09-11 17:14 ` Paolo Bonzini
2020-09-11 17:18 ` Eric Blake
2020-09-11 17:24 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).